public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc
@ 2026-05-30 20:13 Rosen Penev
  2026-06-04  5:08 ` Claude review: " Claude Code Review Bot
  2026-06-04  5:08 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-05-30 20:13 UTC (permalink / raw)
  To: dri-devel
  Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
	Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
	open list:DRM DRIVER for Qualcomm display hardware

The kernel-doc referred to @crtc_clk_rate but the actual parameter is @mode_clk_rate.

Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
index 13cc658065c5..2ff255d7795e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
@@ -34,7 +34,7 @@ enum dpu_perf_mode {
 /**
  * dpu_core_perf_adjusted_mode_clk - Adjust given mode clock rate according to
  *   the perf clock factor.
- * @crtc_clk_rate - Unadjusted mode clock rate
+ * @mode_clk_rate: unadjusted mode clock rate
  * @perf_cfg: performance configuration
  */
 u64 dpu_core_perf_adjusted_mode_clk(u64 mode_clk_rate,
--
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc
  2026-05-30 20:13 [PATCH] drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc Rosen Penev
  2026-06-04  5:08 ` Claude review: " Claude Code Review Bot
@ 2026-06-04  5:08 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04  5:08 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc
Author: Rosen Penev <rosenp@gmail.com>
Patches: 1
Reviewed: 2026-06-04T15:08:55.626391

---

This is a single-patch series that fixes a kernel-doc comment in the DPU display driver. The fix is **correct and straightforward** — it addresses two issues in one line:

1. **Wrong parameter name**: The doc comment referenced `@crtc_clk_rate` but the actual function parameter is `mode_clk_rate`.
2. **Wrong kernel-doc separator**: The original used `-` after the parameter name instead of the correct `:` separator per kernel-doc conventions.

The patch is trivially correct and safe to apply. No functional code changes.

**Recommendation**: Acked. This is a clear documentation fix.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc
  2026-05-30 20:13 [PATCH] drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc Rosen Penev
@ 2026-06-04  5:08 ` Claude Code Review Bot
  2026-06-04  5:08 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04  5:08 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Status**: Correct.

The change at `drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:37`:

```
- * @crtc_clk_rate - Unadjusted mode clock rate
+ * @mode_clk_rate: unadjusted mode clock rate
```

Verified against the function signature at line 40:

```c
u64 dpu_core_perf_adjusted_mode_clk(u64 mode_clk_rate,
```

The parameter is indeed `mode_clk_rate`, not `crtc_clk_rate`. The separator fix from `-` to `:` also aligns with kernel-doc format requirements (kernel-doc uses `@param:` not `@param -`). The capitalization change ("Unadjusted" to "unadjusted") is also consistent with the existing `@perf_cfg` description on the next line which uses lowercase.

**Minor note**: The `Assisted-by: Opencode:Big-pickle` tag is non-standard. The kernel community typically uses `Co-developed-by:` for human collaborators, or specific AI-assistance tags that have been discussed on LKML. This is cosmetic and up to the maintainer whether to accept or request a change to the tag.

No issues with the code change itself.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-04  5:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 20:13 [PATCH] drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc Rosen Penev
2026-06-04  5:08 ` Claude review: " Claude Code Review Bot
2026-06-04  5:08 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox