From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo()
Date: Fri, 05 Jun 2026 06:45:30 +1000 [thread overview]
Message-ID: <review-overall-20260604025315.245910-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260604025315.245910-1-jhubbard@nvidia.com>
Overall Series Review
Subject: libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo()
Author: John Hubbard <jhubbard@nvidia.com>
Patches: 3
Reviewed: 2026-06-05T06:45:30.562685
---
This is a clean, well-motivated 2-patch series that fixes a real `path_noexec()` warning triggered by `CONFIG_DEBUG_VFS=y` on dma-buf mmap. The approach — setting `SB_I_NOEXEC | SB_I_NODEV` in `init_pseudo()` rather than per-caller — is the right level of abstraction, as suggested by Christoph Hellwig. Pseudo-filesystems are `SB_NOUSER` mounts that are never path-reachable, so both flags are safe defaults.
The series is properly structured: patch 1 is the functional fix (with `Fixes:` and `Cc: stable`), and patch 2 is a pure cleanup. The cover letter includes a thorough audit table of all `init_pseudo()` callers, which inspires confidence.
**No correctness issues found.** The series looks ready to merge.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 2:53 [PATCH v3 0/2] libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo() John Hubbard
2026-06-04 2:53 ` [PATCH v3 1/2] libfs: set SB_I_NOEXEC and SB_I_NODEV by default " John Hubbard
2026-06-04 20:45 ` Claude review: " Claude Code Review Bot
2026-06-04 2:53 ` [PATCH v3 2/2] libfs: drop redundant SB_I_NOEXEC/SB_I_NODEV in init_pseudo() callers John Hubbard
2026-06-04 20:45 ` Claude review: " Claude Code Review Bot
2026-06-04 20:45 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604025315.245910-1-jhubbard@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox