From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: libfs: drop redundant SB_I_NOEXEC/SB_I_NODEV in init_pseudo() callers
Date: Fri, 05 Jun 2026 06:45:31 +1000 [thread overview]
Message-ID: <review-patch2-20260604025315.245910-3-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260604025315.245910-3-jhubbard@nvidia.com>
Patch Review
**Status: Looks good.**
This is a pure cleanup removing 10 lines across 6 files. All removals are correct:
| File | What was removed | Correct? |
|------|-----------------|----------|
| `fs/aio.c` | `SB_I_NOEXEC` | Yes — now set by `init_pseudo()` |
| `fs/anon_inodes.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes |
| `fs/nsfs.c` | `SB_I_NOEXEC \| SB_I_NODEV` | Yes |
| `fs/pidfs.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes |
| `mm/secretmem.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes |
| `virt/kvm/guest_memfd.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes |
I verified all 6 callers in the applied tree — none retain any `SB_I_NOEXEC` or `SB_I_NODEV` assignments after `init_pseudo()`, confirming the removals are complete and correct.
The patch intentionally does **not** carry a `Fixes:` tag or `Cc: stable`, which is correct since it's a no-op cleanup that depends on patch 1.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 2:53 [PATCH v3 0/2] libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo() John Hubbard
2026-06-04 2:53 ` [PATCH v3 1/2] libfs: set SB_I_NOEXEC and SB_I_NODEV by default " John Hubbard
2026-06-04 20:45 ` Claude review: " Claude Code Review Bot
2026-06-04 2:53 ` [PATCH v3 2/2] libfs: drop redundant SB_I_NOEXEC/SB_I_NODEV in init_pseudo() callers John Hubbard
2026-06-04 20:45 ` Claude Code Review Bot [this message]
2026-06-04 20:45 ` Claude review: libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo() Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260604025315.245910-3-jhubbard@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox