[PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib

[PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib

[Leonardo Cesar]

Fixes a whitespace indentation issue reported by the smatch static
checker tool.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605081621.Euvx7ORX-lkp@intel.com/
Signed-off-by: Leonardo César <leonardocesar@usp.br>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index f7ebead09..d213a0cdd 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -2725,7 +2725,7 @@ int amdgpu_gfx_ring_preempt_ib(struct amdgpu_ring *ring)
 	}
 
 	/* deassert preemption condition */
-    amdgpu_ring_set_preempt_cond_exec(ring, true);
+	amdgpu_ring_set_preempt_cond_exec(ring, true);
 
 	if (i >= adev->usec_timeout) {
 		DRM_ERROR("ring %d failed to preempt ib\n", ring->idx);
-- 
2.43.0

Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib

[Christian König]

On 5/12/26 16:01, Leonardo Cesar wrote:
> Fixes a whitespace indentation issue reported by the smatch static
> checker tool.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605081621.Euvx7ORX-lkp@intel.com/
> Signed-off-by: Leonardo César <leonardocesar@usp.br>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index f7ebead09..d213a0cdd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -2725,7 +2725,7 @@ int amdgpu_gfx_ring_preempt_ib(struct amdgpu_ring *ring)
>  	}
>  
>  	/* deassert preemption condition */
> -    amdgpu_ring_set_preempt_cond_exec(ring, true);
> +	amdgpu_ring_set_preempt_cond_exec(ring, true);
>  
>  	if (i >= adev->usec_timeout) {
>  		DRM_ERROR("ring %d failed to preempt ib\n", ring->idx);

Claude review: Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib

[Claude Code Review Bot]

Overall Series Review

Subject: Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib
Author: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Patches: 2
Reviewed: 2026-05-16T12:23:11.504297

---

This is a single-patch series that fixes a whitespace/indentation issue in `amdgpu_gfx_ring_preempt_ib()`. The fix is trivially correct: one line was indented with 4 spaces instead of a tab, inconsistent with the rest of the function and with kernel coding style. The issue was flagged by the smatch static checker via the kernel test robot.

**Verdict: Looks good.** Straightforward style fix, no functional change.

---
Generated by Claude Code Patch Reviewer

Claude review: Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib

[Claude Code Review Bot]

Patch Review

**Status: Correct, minor commit message nit**

The fix itself is obviously correct. I verified against the current drm-next tree at line 2730 of `amdgpu_gfx.c`:

```c
	/* deassert preemption condition */
    amdgpu_ring_set_preempt_cond_exec(ring, true);
```

The line uses 4 spaces for indentation, while every other line in the function uses tabs. The patch replaces the spaces with a tab:

```c
	/* deassert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, true);
```

This aligns it with the matching call earlier in the function (line 2711):

```c
	/* assert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, false);
```

**Minor nit on commit message:** The commit message says "Fixes a whitespace indentation issue reported by the smatch static checker tool" but doesn't include a `Fixes:` tag pointing to the commit that introduced the bad indentation. For a pure whitespace fix this is arguably unnecessary, but if reviewers want one, it would point to the commit that introduced the space-indented line. This is not a blocker.

**No functional concerns.** The patch is a trivial whitespace-only change with no behavioral impact.

---
Generated by Claude Code Patch Reviewer