public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "dt-bindings: display: bridge: ldb: Add check for reg and reg-names"
Date: Tue, 05 May 2026 07:44:15 +1000	[thread overview]
Message-ID: <review-patch1-20260504-v7-1-topic-ldb-fixes-v1-1-0125d937ff7f@pengutronix.de> (raw)
In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-1-0125d937ff7f@pengutronix.de>

Patch Review

This reverts commit `8aa2f0ac08d3`, removing the `reg` requirement from the `required:` list and the conditional `reg-names` requirement for non-imx6sx variants.

**Changes reviewed:**

```yaml
-  - reg
```
removed from the `required:` block, and the entire conditional block:
```yaml
-  - if:
-      not:
-        properties:
-          compatible:
-            contains:
-              const: fsl,imx6sx-ldb
-    then:
-      required:
-        - reg-names
```
is also removed.

**Assessment:** Correct. The commit message clearly explains why — the syscon register ranges have multi-purpose registers and `reg` per sub-device is wrong. The revert is clean and the remaining schema (`fsl,ldb.yaml`) remains valid without the `reg` requirement.

**Minor nit:** The commit message has a typo "controlls" (should be "controls") — same typo appears in patches 2 and 3. Not blocking.

**No issues.**

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 20:21 [PATCH 0/4] i.MX LDB DT cleanups Marco Felsch
2026-05-04 20:21 ` [PATCH 1/4] Revert "dt-bindings: display: bridge: ldb: Add check for reg and reg-names" Marco Felsch
2026-05-04 21:44   ` Claude Code Review Bot [this message]
2026-05-04 20:21 ` [PATCH 2/4] Revert "dt-bindings: display: bridge: ldb: Fill in reg property" Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 3/4] ARM: dts: imx6sx: remove LDB reg property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 4/4] arm64: dts: imx8mp: remove LDB reg and reg-names property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 21:44 ` Claude review: i.MX LDB DT cleanups Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260504-v7-1-topic-ldb-fixes-v1-1-0125d937ff7f@pengutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox