public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "dt-bindings: display: bridge: ldb: Fill in reg property"
Date: Tue, 05 May 2026 07:44:15 +1000	[thread overview]
Message-ID: <review-patch2-20260504-v7-1-topic-ldb-fixes-v1-2-0125d937ff7f@pengutronix.de> (raw)
In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-2-0125d937ff7f@pengutronix.de>

Patch Review

This reverts commit `16c8d76abe83`, removing the `reg` and `reg-names` property definitions themselves from the binding schema, and updating the example to match.

**Changes reviewed:**

Property definitions removed:
```yaml
-  reg:
-    maxItems: 2
-
-  reg-names:
-    items:
-      - const: ldb
-      - const: lvds
```

Example updated — removes `#address-cells`, `#size-cells` from the parent `blk-ctrl` node, and `reg`/`reg-names` from the bridge child:
```yaml
-        #address-cells = <1>;
-        #size-cells = <1>;
-
-        bridge@5c {
+        bridge {
             compatible = "fsl,imx8mp-ldb";
-            reg = <0x5c 0x4>, <0x128 0x4>;
-            reg-names = "ldb", "lvds";
```

**Assessment:** Correct. The resulting binding file (verified above) is clean and consistent. The example no longer needs `#address-cells`/`#size-cells` in the parent since no child has a `reg` property with a unit address. The binding still has `additionalProperties: false`, which will correctly reject any DTS that still tries to pass `reg` — this is fine since patches 3 and 4 clean up the actual DTS files.

**One observation:** Since `additionalProperties: false` is set, after this patch but before patches 3-4, running `dt_binding_check` against the existing imx8mp/imx6sx DTS files would produce schema validation warnings (the DTS files still have `reg` properties that the schema now disallows). This is a transient bisection issue — not a problem in practice since the series is applied atomically, but worth noting. Some maintainers prefer DTS changes before binding changes to avoid this. The current ordering (binding first, DTS second) is also commonly accepted.

**No blocking issues.**

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 20:21 [PATCH 0/4] i.MX LDB DT cleanups Marco Felsch
2026-05-04 20:21 ` [PATCH 1/4] Revert "dt-bindings: display: bridge: ldb: Add check for reg and reg-names" Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 2/4] Revert "dt-bindings: display: bridge: ldb: Fill in reg property" Marco Felsch
2026-05-04 21:44   ` Claude Code Review Bot [this message]
2026-05-04 20:21 ` [PATCH 3/4] ARM: dts: imx6sx: remove LDB reg property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 4/4] arm64: dts: imx8mp: remove LDB reg and reg-names property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 21:44 ` Claude review: i.MX LDB DT cleanups Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260504-v7-1-topic-ldb-fixes-v1-2-0125d937ff7f@pengutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox