From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx8mp: remove LDB reg and reg-names property
Date: Tue, 05 May 2026 07:44:16 +1000 [thread overview]
Message-ID: <review-patch4-20260504-v7-1-topic-ldb-fixes-v1-4-0125d937ff7f@pengutronix.de> (raw)
In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-4-0125d937ff7f@pengutronix.de>
Patch Review
Removes `reg`, `reg-names`, and the unit address from the bridge node in `imx8mp.dtsi`.
**Changes reviewed:**
```dts
- lvds_bridge: bridge@5c {
+ lvds_bridge: bridge {
compatible = "fsl,imx8mp-ldb";
- reg = <0x5c 0x4>, <0x128 0x4>;
- reg-names = "ldb", "lvds";
```
**Assessment:** Correct. The offsets `0x5c` and `0x128` match the hardcoded `.ldb_ctrl = 0x5c` and `.lvds_ctrl = 0x128` in `fsl_ldb_devdata[IMX8MP_LDB]`, confirming redundancy. The parent `media_blk_ctrl` retains its `#address-cells`/`#size-cells` for other children.
The commit message has the same "porperty" typo (should be "property"). Not blocking.
**No issues.**
---
**Summary:** Clean, well-motivated series with correct ordering and no functional risk. The only cosmetic nits are minor typos ("controlls", "porperty") in commit messages. No code changes are needed — this is purely a DT cleanup that removes properties the driver never consumed.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 20:21 [PATCH 0/4] i.MX LDB DT cleanups Marco Felsch
2026-05-04 20:21 ` [PATCH 1/4] Revert "dt-bindings: display: bridge: ldb: Add check for reg and reg-names" Marco Felsch
2026-05-04 21:44 ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 2/4] Revert "dt-bindings: display: bridge: ldb: Fill in reg property" Marco Felsch
2026-05-04 21:44 ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 3/4] ARM: dts: imx6sx: remove LDB reg property Marco Felsch
2026-05-04 21:44 ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 4/4] arm64: dts: imx8mp: remove LDB reg and reg-names property Marco Felsch
2026-05-04 21:44 ` Claude Code Review Bot [this message]
2026-05-04 21:44 ` Claude review: i.MX LDB DT cleanups Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260504-v7-1-topic-ldb-fixes-v1-4-0125d937ff7f@pengutronix.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox