public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: i.MX LDB DT cleanups
Date: Tue, 05 May 2026 07:44:14 +1000	[thread overview]
Message-ID: <review-overall-20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de> (raw)
In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de>

Overall Series Review

Subject: i.MX LDB DT cleanups
Author: Marco Felsch <m.felsch@pengutronix.de>
Patches: 5
Reviewed: 2026-05-05T07:44:14.436314

---

This is a clean 4-patch series that removes the unused `reg` and `reg-names` device tree properties from the fsl,ldb (LVDS Display Bridge) binding and associated DTS files. The rationale is sound: the LDB driver (`drivers/gpu/drm/bridge/fsl-ldb.c`) has **never** used these properties. It obtains register access via `syscon_node_to_regmap(dev->of_node->parent)` and uses hardcoded offsets from per-device-type driver data. The parent syscon nodes (IOMUX_GPR, BLK_CTRL) have multi-purpose registers shared across sub-devices, making per-sub-device `reg` properties semantically incorrect.

The ordering is correct: revert the binding schema additions first (patches 1-2), then remove the properties from the DTS files (patches 3-4). The final binding YAML and DTS files are consistent and well-formed.

The cover letter honestly notes "I didn't do runtime tests" — this is acceptable given the driver provably ignores these properties, so there is no functional change.

**Verdict: Series looks good. No blocking issues.**

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-04 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 20:21 [PATCH 0/4] i.MX LDB DT cleanups Marco Felsch
2026-05-04 20:21 ` [PATCH 1/4] Revert "dt-bindings: display: bridge: ldb: Add check for reg and reg-names" Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 2/4] Revert "dt-bindings: display: bridge: ldb: Fill in reg property" Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 3/4] ARM: dts: imx6sx: remove LDB reg property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 20:21 ` [PATCH 4/4] arm64: dts: imx8mp: remove LDB reg and reg-names property Marco Felsch
2026-05-04 21:44   ` Claude review: " Claude Code Review Bot
2026-05-04 21:44 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox