From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h
Date: Mon, 25 May 2026 19:30:20 +1000 [thread overview]
Message-ID: <review-patch1-20260521224137.628035-1-maaz.mombasawala@broadcom.com> (raw)
In-Reply-To: <20260521224137.628035-1-maaz.mombasawala@broadcom.com>
Patch Review
**Correctness of the duplicate claim:**
The removed functions in `vmwgfx_bo.h`:
```c
static inline struct vmw_bo *vmw_user_bo_ref(struct vmw_bo *vbo)
{
drm_gem_object_get(&vbo->tbo.base);
return vbo;
}
static inline void vmw_user_bo_unref(struct vmw_bo **buf)
{
struct vmw_bo *tmp_buf = *buf;
*buf = NULL;
if (tmp_buf)
drm_gem_object_put(&tmp_buf->tbo.base);
}
```
are indeed identical to the retained functions in the same file:
```c
static inline struct vmw_bo *vmw_bo_reference(struct vmw_bo *buf)
{
drm_gem_object_get(&buf->tbo.base);
return buf;
}
static inline void vmw_bo_unreference(struct vmw_bo **buf)
{
struct vmw_bo *tmp_buf = *buf;
*buf = NULL;
if (tmp_buf)
drm_gem_object_put(&tmp_buf->tbo.base);
}
```
The only difference is the parameter name (`vbo` vs `buf`), which has no semantic impact.
**Caller updates:** All 17 call sites across 9 files are mechanically updated — each `vmw_user_bo_ref` → `vmw_bo_reference`, each `vmw_user_bo_unref` → `vmw_bo_unreference`. The argument types and pointer-to-pointer semantics are preserved correctly in every instance.
**Forward declaration cleanup (`vmwgfx_drv.h`):** The patch also removes one of two identical `struct vmw_bo;` forward declarations. The remaining one at line 99 is sufficient.
**No issues found.** This is a clean, correct deduplication.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 22:41 [PATCH] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-25 9:30 ` Claude Code Review Bot [this message]
2026-05-25 9:30 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 22:48 [PATCH v3 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-14 22:48 ` [PATCH v3 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
2026-05-12 0:27 [PATCH v2 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-12 0:27 ` [PATCH v2 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260521224137.628035-1-maaz.mombasawala@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox