public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h
Date: Mon, 25 May 2026 19:30:20 +1000	[thread overview]
Message-ID: <review-overall-20260521224137.628035-1-maaz.mombasawala@broadcom.com> (raw)
In-Reply-To: <20260521224137.628035-1-maaz.mombasawala@broadcom.com>

Overall Series Review

Subject: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h
Author: Maaz Mombasawala <maaz.mombasawala@broadcom.com>
Patches: 1
Reviewed: 2026-05-25T19:30:20.019359

---

This is a straightforward, correct cleanup patch. It removes two inline functions (`vmw_user_bo_ref` and `vmw_user_bo_unref`) from `vmwgfx_bo.h` that are exact duplicates of the existing `vmw_bo_reference` and `vmw_bo_unreference` in the same header, and updates all callers. It also removes a duplicate `struct vmw_bo;` forward declaration in `vmwgfx_drv.h`.

The code transformation is entirely mechanical — every `vmw_user_bo_ref(x)` becomes `vmw_bo_reference(x)` and every `vmw_user_bo_unref(&x)` becomes `vmw_bo_unreference(&x)`. The replacement functions have identical signatures and identical bodies (`drm_gem_object_get`/`drm_gem_object_put` on the same `tbo.base` member), so there is no behavioral change.

**Verdict: Looks good.** No issues found.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 22:41 [PATCH] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-25  9:30 ` Claude Code Review Bot [this message]
2026-05-25  9:30 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-14 22:48 [PATCH v3 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-14 22:48 ` [PATCH v3 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16  0:17   ` Claude review: " Claude Code Review Bot
2026-05-12  0:27 [PATCH v2 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-12  0:27 ` [PATCH v2 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16  4:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260521224137.628035-1-maaz.mombasawala@broadcom.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox