From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: inline some init methods
Date: Thu, 04 Jun 2026 16:23:29 +1000 [thread overview]
Message-ID: <review-patch1-20260530-nova-exports-v3-1-1202aa339ef7@nvidia.com> (raw)
In-Reply-To: <20260530-nova-exports-v3-1-1202aa339ef7@nvidia.com>
Patch Review
**Status: Looks good**
Adds `#[inline]` to five methods across three files: `write_init` and `write_pin_init` on `Box<MaybeUninit<T>>` and `UniqueArc<MaybeUninit<T>>`, plus `pin_init` in the `InPlaceInit` trait.
The rationale is sound — these are generic methods that, when monomorphized with complex type parameters, produce excessively long mangled symbol names that exceed `modpost`/`objtool` limits. Using `#[inline]` (not `#[inline(always)]`) is the right choice: it hints the compiler without forcing inlining in every case. The cover letter notes that methods returning `impl PinInit` were deliberately excluded since they don't contribute to the long symbol name problem.
All five methods are small wrappers around unsafe blocks that delegate to `Init::__init` or `PinInit::__pinit`, making them good inlining candidates regardless of the symbol name motivation.
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 15:27 [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-05-29 15:27 ` [PATCH v3 1/5] rust: inline some init methods Alexandre Courbot
2026-06-03 11:52 ` Gary Guo
2026-06-04 6:23 ` Claude Code Review Bot [this message]
2026-05-29 15:27 ` [PATCH v3 2/5] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 3/5] gpu: nova-core: emit Rust metadata " Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 4/5] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH POC v3 5/5] drm: nova: demonstrate interaction with nova-core Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-06-01 13:50 ` [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Miguel Ojeda
2026-06-01 17:00 ` Miguel Ojeda
2026-06-03 10:30 ` Alexandre Courbot
2026-06-03 11:49 ` Miguel Ojeda
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260530-nova-exports-v3-1-1202aa339ef7@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox