From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: export Rust symbols for dependent modules
Date: Thu, 04 Jun 2026 16:23:29 +1000 [thread overview]
Message-ID: <review-patch2-20260530-nova-exports-v3-2-1202aa339ef7@nvidia.com> (raw)
In-Reply-To: <20260530-nova-exports-v3-2-1202aa339ef7@nvidia.com>
Patch Review
**Status: Acceptable as a workaround, with a concern**
This generates `EXPORT_SYMBOL_GPL()` calls for all Rust global text symbols in `nova_core.o` by piping `nm` output through `awk`:
```makefile
rust_exports = \
$(NM) -p --defined-only $(1) | \
awk '$$2 == "T" && $$3 ~ /^_R/ { \
printf "extern void %s(void); EXPORT_SYMBOL_GPL(%s);\n", $$3, $$3 \
}'
```
The filter is correct: Rust v0 mangled symbols start with `_R`, and checking `$$2 == "T"` restricts to global text symbols. The generated `extern void fn(void)` declarations are technically mistyped, but since only `EXPORT_SYMBOL_GPL()` uses them (no C code actually calls them with this signature), this is harmless.
**Concern: over-exporting.** This exports *every* Rust text symbol from nova-core, not just the ones nova-drm actually needs. This means internal implementation details, monomorphized generics, trait method implementations, etc. all become part of the module's exported API. While acceptable as a temporary workaround, this could interact poorly with symbol versioning or module loading if any internal symbols change. A more targeted approach (e.g., an explicit symbol list) would be cleaner but harder to maintain as a workaround.
The module composite object rename from `nova_core.o` → `nova-core.o` with `nova-core-y := nova_core.o nova_core_exports.o` is clean and follows standard Kbuild patterns.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 15:27 [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-05-29 15:27 ` [PATCH v3 1/5] rust: inline some init methods Alexandre Courbot
2026-06-03 11:52 ` Gary Guo
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 2/5] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-06-04 6:23 ` Claude Code Review Bot [this message]
2026-05-29 15:27 ` [PATCH v3 3/5] gpu: nova-core: emit Rust metadata " Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 4/5] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH POC v3 5/5] drm: nova: demonstrate interaction with nova-core Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-06-01 13:50 ` [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Miguel Ojeda
2026-06-01 17:00 ` Miguel Ojeda
2026-06-03 10:30 ` Alexandre Courbot
2026-06-03 11:49 ` Miguel Ojeda
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 11:52 [PATCH v2 0/7] " Alexandre Courbot
2026-05-27 11:52 ` [PATCH v2 4/7] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-05-28 2:22 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 [PATCH 0/7] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-04-30 14:55 ` [PATCH 4/7] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260530-nova-exports-v3-2-1202aa339ef7@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox