Claude review: gpu: drm: nova: enable calling into nova-core

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: drm: nova: enable calling into nova-core
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 11
Reviewed: 2026-06-04T16:23:29.159435

---

This is a 5-patch series from Alexandre Courbot (NVIDIA) that enables `nova-drm` to call into `nova-core` by working around the current lack of native Rust cross-crate module dependency support in the kernel build system. The approach has three parts: (1) inline some Rust init methods to avoid excessively long symbol names, (2) export nova-core's Rust symbols via a generated C file with `EXPORT_SYMBOL_GPL()`, and (3) emit Rust `.rmeta` metadata so nova-drm can resolve nova-core's types at compile time.

**Strengths:**
- Well-documented as a temporary workaround with clear rationale
- The `#[inline]` patch (1/5) has standalone merit beyond the workaround
- Build system integration is thoughtful (private directory to avoid parallel build races, order-only dependencies, `filechk` for generated headers)
- Patch 5 is honestly labeled as POC/not-for-merge

**Concerns:**
- Patch 2 exports ALL Rust text symbols from nova-core, which is far more than nova-drm needs — this leaks internal API surface via `EXPORT_SYMBOL_GPL()`
- Patch 3 effectively compiles nova-core twice (once for the .o, once for the .rmeta), increasing build time
- The patches are based on `drm-rust-next` which has diverged significantly from the `drm-next` tree (the whole `'bound` lifetime / HRT v5 infrastructure), so they could not be verified against the reference tree

**Overall: The series is a reasonable pragmatic workaround. Patches 1-4 look correct for their stated purpose. The POC patch 5 demonstrates sound design for the inter-module data flow but has some rough edges typical of demo code.**

---

---
Generated by Claude Code Patch Reviewer