From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: nova: build after nova-core metadata
Date: Thu, 04 Jun 2026 16:23:30 +1000 [thread overview]
Message-ID: <review-patch4-20260530-nova-exports-v3-4-1202aa339ef7@nvidia.com> (raw)
In-Reply-To: <20260530-nova-exports-v3-4-1202aa339ef7@nvidia.com>
Patch Review
**Status: Looks good**
Wires up nova-drm to consume nova-core's metadata:
```makefile
nova_core_rmeta := drivers/gpu/nova-core/libnova_core.rmeta
rustflags-y += --extern nova_core=$(objtree)/$(nova_core_rmeta)
$(obj)/nova.o: | $(objtree)/$(nova_core_rmeta)
```
The order-only dependency (`|`) is correct — nova-drm needs the rmeta to exist before compilation but doesn't need to rebuild when the rmeta content changes (since symbol resolution happens at module load time via the exports from patch 2).
The recursive `$(MAKE) $(build)=...` to build the rmeta target in another directory is ugly (as the comment acknowledges) but functional. This is the standard kernel pattern for cross-directory build dependencies.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 15:27 [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-05-29 15:27 ` [PATCH v3 1/5] rust: inline some init methods Alexandre Courbot
2026-06-03 11:52 ` Gary Guo
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 2/5] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 3/5] gpu: nova-core: emit Rust metadata " Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-05-29 15:27 ` [PATCH v3 4/5] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-06-04 6:23 ` Claude Code Review Bot [this message]
2026-05-29 15:27 ` [PATCH POC v3 5/5] drm: nova: demonstrate interaction with nova-core Alexandre Courbot
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
2026-06-01 13:50 ` [PATCH v3 0/5] gpu: drm: nova: enable calling into nova-core Miguel Ojeda
2026-06-01 17:00 ` Miguel Ojeda
2026-06-03 10:30 ` Alexandre Courbot
2026-06-03 11:49 ` Miguel Ojeda
2026-06-04 6:23 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 11:52 [PATCH v2 0/7] " Alexandre Courbot
2026-05-27 11:52 ` [PATCH v2 6/7] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-05-28 2:22 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 [PATCH 0/7] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-04-30 14:55 ` [PATCH 6/7] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260530-nova-exports-v3-4-1202aa339ef7@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox