public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbcon: Put font-rotation state into separate struct
Date: Sun, 12 Apr 2026 13:55:03 +1000	[thread overview]
Message-ID: <review-patch10-20260407092555.58816-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20260407092555.58816-11-tzimmermann@suse.de>

Patch Review

**Verdict: Good organization.**

Moves all rotation-related state into a nested `struct rotated` inside `fbcon_par`, guarded by `CONFIG_FRAMEBUFFER_CONSOLE_ROTATION`. This cleanly separates rotation concerns from core fbcon state and avoids allocating unused fields when rotation is disabled.

The field rename `fontdata` to `rotated.fontdata` (now typed as `font_data_t *`) and comparison change from `vc->vc_font.data` to `par->p->fontdata` is consistent with the prerequisite series's introduction of `font_data_t`. The rotation comparison change from `par->p->con_rotate` to `par->rotate` is semantically correct (checking the par's own rotation value against what was cached).

The `#ifdef` guards around `kfree(par->rotated.buf)` in `fbcon_release` and initialization in `fbcon_startup` are necessary and correct.

No issues.

---

**Summary**: The series is well-crafted overall but **patch 7 has a bug in `__font_glyph_rotate_180`** that will corrupt 180-degree rotation for fonts with non-byte-aligned widths. This needs to be fixed. All other patches look correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-12  3:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:23 [PATCH v2 00/10] fbcon,fonts: Refactor framebuffer console rotation Thomas Zimmermann
2026-04-07  9:23 ` [PATCH v2 01/10] fbcon: Avoid OOB font access if console rotation fails Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 02/10] vt: Implement helpers for struct vc_font in source file Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 03/10] lib/fonts: Provide helpers for calculating glyph pitch and size Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 04/10] lib/fonts: Clean up Makefile Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 05/10] lib/fonts: Implement glyph rotation Thomas Zimmermann
2026-04-07 15:48   ` Helge Deller
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 06/10] lib/fonts: Refactor glyph-pattern helpers Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 07/10] lib/fonts: Refactor glyph-rotation helpers Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 08/10] lib/fonts: Implement font rotation Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 09/10] fbcon: Fill cursor mask in helper function Thomas Zimmermann
2026-04-12  3:55   ` Claude review: " Claude Code Review Bot
2026-04-07  9:23 ` [PATCH v2 10/10] fbcon: Put font-rotation state into separate struct Thomas Zimmermann
2026-04-12  3:55   ` Claude Code Review Bot [this message]
2026-04-12  3:55 ` Claude review: fbcon,fonts: Refactor framebuffer console rotation Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch10-20260407092555.58816-11-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox