From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: lib/fonts: Refactor glyph-pattern helpers
Date: Sun, 12 Apr 2026 13:55:02 +1000 [thread overview]
Message-ID: <review-patch6-20260407092555.58816-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20260407092555.58816-7-tzimmermann@suse.de>
Patch Review
**Verdict: Clean refactor.**
Introduces `__font_glyph_pos()` to centralize the bit position calculation, plus `font_glyph_test_bit()` and `font_glyph_set_bit()`. The new helpers change signatures from `(x, y, pitch, pat)` to `(glyph, x, y, bit_pitch)` -- buffer-first, consistent with other `font_glyph_*` APIs.
The refactoring is purely mechanical. The rotation functions themselves are updated to call the new helpers but the bit manipulation logic is unchanged. Verified that the coordinate computations in all three rotation functions remain identical.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 9:23 [PATCH v2 00/10] fbcon,fonts: Refactor framebuffer console rotation Thomas Zimmermann
2026-04-07 9:23 ` [PATCH v2 01/10] fbcon: Avoid OOB font access if console rotation fails Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 02/10] vt: Implement helpers for struct vc_font in source file Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 03/10] lib/fonts: Provide helpers for calculating glyph pitch and size Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 04/10] lib/fonts: Clean up Makefile Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 05/10] lib/fonts: Implement glyph rotation Thomas Zimmermann
2026-04-07 15:48 ` Helge Deller
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 06/10] lib/fonts: Refactor glyph-pattern helpers Thomas Zimmermann
2026-04-12 3:55 ` Claude Code Review Bot [this message]
2026-04-07 9:23 ` [PATCH v2 07/10] lib/fonts: Refactor glyph-rotation helpers Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 08/10] lib/fonts: Implement font rotation Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 09/10] fbcon: Fill cursor mask in helper function Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 10/10] fbcon: Put font-rotation state into separate struct Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-12 3:55 ` Claude review: fbcon,fonts: Refactor framebuffer console rotation Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260407092555.58816-7-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox