From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: lib/fonts: Implement glyph rotation
Date: Sun, 12 Apr 2026 13:55:02 +1000 [thread overview]
Message-ID: <review-patch5-20260407092555.58816-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20260407092555.58816-6-tzimmermann@suse.de>
Patch Review
**Verdict: Correct code movement.**
Moves `pattern_test_bit`, `pattern_set_bit`, `rotate_cw`, `rotate_ud`, `rotate_ccw` from `fbcon_rotate.h` (static inlines) into `lib/fonts/font_rotate.c`. Wraps them in public API functions (`font_glyph_rotate_90/180/270`) that add a `memset(out, 0, ...)` before calling the internal rotate. This is important since the `set_bit` functions only OR bits in.
The commit message correctly notes that this trades one bulk `memset` (old code zeroed the entire font buffer) for per-glyph `memset` calls, but this will be optimized again in patch 8. The `EXPORT_SYMBOL_GPL` is appropriate since the callers are in a different module.
The interface change placing `out` as the last parameter (matching kernel convention for output buffers) is a nice touch.
No issues with the logic -- this is a pure code movement with no behavioral changes to the rotation algorithms themselves.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 9:23 [PATCH v2 00/10] fbcon,fonts: Refactor framebuffer console rotation Thomas Zimmermann
2026-04-07 9:23 ` [PATCH v2 01/10] fbcon: Avoid OOB font access if console rotation fails Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 02/10] vt: Implement helpers for struct vc_font in source file Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 03/10] lib/fonts: Provide helpers for calculating glyph pitch and size Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 04/10] lib/fonts: Clean up Makefile Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 05/10] lib/fonts: Implement glyph rotation Thomas Zimmermann
2026-04-07 15:48 ` Helge Deller
2026-04-12 3:55 ` Claude Code Review Bot [this message]
2026-04-07 9:23 ` [PATCH v2 06/10] lib/fonts: Refactor glyph-pattern helpers Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 07/10] lib/fonts: Refactor glyph-rotation helpers Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 08/10] lib/fonts: Implement font rotation Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 09/10] fbcon: Fill cursor mask in helper function Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-07 9:23 ` [PATCH v2 10/10] fbcon: Put font-rotation state into separate struct Thomas Zimmermann
2026-04-12 3:55 ` Claude review: " Claude Code Review Bot
2026-04-12 3:55 ` Claude review: fbcon,fonts: Refactor framebuffer console rotation Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260407092555.58816-6-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox