public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mipi-dsi: Add flag to support dual-panel configurations
Date: Mon, 25 May 2026 20:00:02 +1000	[thread overview]
Message-ID: <review-patch2-20260521-sm8650-7-1-bonded-dsi-v4-2-a4dd5e0850f1@linaro.org> (raw)
In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-2-a4dd5e0850f1@linaro.org>

Patch Review

**Concept**: Adds a `bool dual_panel` to `struct mipi_dsi_device` so a panel driver can signal the DSI host that it's part of a dual-panel setup.

**Issues:**

1. **Generic name, MSM-specific semantics**: The field is added to the core DRM MIPI DSI header (`include/drm/drm_mipi_dsi.h`), making it part of the cross-driver API. However, only the MSM DSI host consumes it. The commit message describes very MSM-specific behavior (bonded-DSI, shared clock from DSI0 PHY). Other DSI host drivers won't understand this flag. If the intent is for this to be a generic DRM concept, the semantics need proper documentation and potentially discussion on dri-devel about what "dual_panel" means generically vs. bonded DSI.

2. **No documentation of expected behavior**: The field lacks a kerneldoc description of what a host driver should *do* when it sees this flag set. The commit message talks about halving horizontal timings, but that's buried in the cover letter and patch 3, not in the header.

3. **Name ambiguity**: `dual_panel` could mean many things — two panels on different CRTCs, a dual-scan panel, etc. Something like `bonded_panel` or `is_bonded_dsi_panel` would be clearer about the intended semantics.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 10:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 14:46 [PATCH v4 0/5] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-05-21 14:46 ` [PATCH v4 1/5] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 2/5] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-05-25 10:00   ` Claude Code Review Bot [this message]
2026-05-21 14:46 ` [PATCH v4 3/5] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 4/5] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-05-21 19:45   ` Conor Dooley
2026-05-21 20:24   ` Dmitry Baryshkov
2026-05-22  6:32     ` Neil Armstrong
2026-05-21 20:46   ` Rob Herring (Arm)
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 5/5] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-25 10:00 ` Claude review: Add support to 2 panels in bonded-DSI mode Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260521-sm8650-7-1-bonded-dsi-v4-2-a4dd5e0850f1@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox