public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: Support dual panel use case with single CRTC
Date: Mon, 25 May 2026 20:00:02 +1000	[thread overview]
Message-ID: <review-patch3-20260521-sm8650-7-1-bonded-dsi-v4-3-a4dd5e0850f1@linaro.org> (raw)
In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-3-a4dd5e0850f1@linaro.org>

Patch Review

**Concept**: When `is_dual_panel` is set, halves `dsc->pic_width` and `pic_width` in check_dsc so the DSI host configures DSC for a single panel's width.

**Issues:**

1. **Correct fix for `dsc->pic_width`**: In `dsi_timing_setup()`, the existing code (line 1033 upstream) sets `dsc->pic_width = mode->hdisplay`, which is indeed wrong for bonded DSI since `mode->hdisplay` is the full doubled width. The patch changes this to use `hdisplay` (the local variable), which is correct for bonded DSI (`hdisplay` was already halved on line 1019). However, the patch uses `msm_host->is_dual_panel` to decide, while the existing `is_bonded_dsi` parameter already covers this case. This creates two overlapping concepts:
   - `is_bonded_dsi`: the existing bonded DSI path (already halves timings)
   - `is_dual_panel`: the new dual-panel path
   
   The patch only sets `dsc->pic_width = hdisplay` when `is_dual_panel` is true, but `hdisplay` has already been halved for `is_bonded_dsi` as well. So for the existing bonded-DSI-with-single-panel case, `dsc->pic_width` is still set to `mode->hdisplay` (the full width), which appears to be a pre-existing bug that this patch doesn't fix. The relationship between these two flags needs clarification.

2. **`msm_dsi_host_check_dsc` fix is incomplete**: The patch adds:
   ```c
   if (msm_host->is_dual_panel)
       pic_width = mode->hdisplay / 2;
   ```
   But `pic_width` was already initialized to `mode->hdisplay` on the previous line. The fix works but note that `is_bonded_dsi` (the existing bonded DSI flag, not dual_panel) also requires halving for the pre-existing single-panel bonded case. This function currently has no concept of `is_bonded_dsi` at all, which may be an existing limitation.

3. **Commit message typo**: "togehter" → "together" in line "While the DSI panel driver should manage two panels togehter."

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 10:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 14:46 [PATCH v4 0/5] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-05-21 14:46 ` [PATCH v4 1/5] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 2/5] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 3/5] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-05-25 10:00   ` Claude Code Review Bot [this message]
2026-05-21 14:46 ` [PATCH v4 4/5] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-05-21 19:45   ` Conor Dooley
2026-05-21 20:24   ` Dmitry Baryshkov
2026-05-22  6:32     ` Neil Armstrong
2026-05-21 20:46   ` Rob Herring (Arm)
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 5/5] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-25 10:00 ` Claude review: Add support to 2 panels in bonded-DSI mode Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260521-sm8650-7-1-bonded-dsi-v4-3-a4dd5e0850f1@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox