public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add support to 2 panels in bonded-DSI mode
Date: Mon, 25 May 2026 20:00:01 +1000	[thread overview]
Message-ID: <review-overall-20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org> (raw)
In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org>

Overall Series Review

Subject: Add support to 2 panels in bonded-DSI mode
Author: Jun Nie <jun.nie@linaro.org>
Patches: 10
Reviewed: 2026-05-25T20:00:01.551184

---

This v4 series adds support for driving two independent physical DSI panels in bonded-DSI mode from a single CRTC, targeting VR headset use cases (left/right eye panels). It touches the MSM DSI host driver to support `slice_per_pkt > 1` for DSC and dual-panel frame width halving, adds a `dual_panel` flag to the core MIPI DSI struct, introduces a new DT binding, and adds a panel driver for the Synaptics R63455. 

The overall architecture — having the panel driver register the second DSI device and set `dual_panel` so the host halves the frame — is reasonable, though several issues need attention before this can be merged:

1. **Build breakage**: The panel driver uses `backlight_properties.pulse_offset_rows`, which does not exist in the kernel backlight struct. This will fail to compile.
2. **`dsc_slice_per_pkt` placement**: Adding a non-standard field to `struct drm_dsc_config` (a struct that maps to the DSC standard parameter set) is debatable and needs DRM maintainer buy-in.
3. **Missing division-by-zero guard**: `dsc_slice_per_pkt` is used as a divisor without validation.
4. **DT binding issues**: YAML schema errors and questionable use of vendor-prefixed supply names instead of generic ones.
5. **Panel driver quality**: Uses deprecated API (`of_device_get_match_data`), includes an unused header, and has error-handling gaps.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25 10:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 14:46 [PATCH v4 0/5] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-05-21 14:46 ` [PATCH v4 1/5] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 2/5] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 3/5] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 4/5] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-05-21 19:45   ` Conor Dooley
2026-05-21 20:24   ` Dmitry Baryshkov
2026-05-22  6:32     ` Neil Armstrong
2026-05-21 20:46   ` Rob Herring (Arm)
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 5/5] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-05-25 10:00   ` Claude review: " Claude Code Review Bot
2026-05-25 10:00 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox