From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: Add Synaptics R63455 panel support
Date: Mon, 25 May 2026 20:00:02 +1000 [thread overview]
Message-ID: <review-patch4-20260521-sm8650-7-1-bonded-dsi-v4-4-a4dd5e0850f1@linaro.org> (raw)
In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-4-a4dd5e0850f1@linaro.org>
Patch Review
**Concept**: DT binding for a dual-panel VR display driven by Synaptics R63455 controllers.
**Issues:**
1. **YAML schema error in `ports`**: The line:
```yaml
ports: $ref: /schemas/graph.yaml#/properties/ports
```
This is incorrect YAML syntax. It should be:
```yaml
ports:
$ref: /schemas/graph.yaml#/properties/ports
```
2. **Non-standard supply naming**: Using `left-pos-supply`, `right-neg-supply`, etc. is unusual. DT bindings typically use generic supply names or names derived from the chip's pin names (e.g., `vpos-left-supply`). The `left-`/`right-` prefix convention isn't established in existing bindings. DT maintainers may push back on this.
3. **Missing port definitions**: The `ports` property references the graph schema but doesn't define `port@0` and `port@1` with their own descriptions within the schema, so the binding doesn't actually constrain or document which ports exist.
4. **Example has syntax issues**: The example DT uses `&mdss_dsi0 { ... }` overlay syntax with missing closing braces. The `};` for the `panel@0` node appears to close at the wrong level (the `};` on line 972 closes the ports node, but the panel node itself is not properly closed before `&mdss_dsi0_out`). This would fail `dt_binding_check`.
5. **`data-lanes` in example**: The example shows `data-lanes = <0 1 2>;` (3 lanes), which matches the panel driver, but this property isn't defined in the binding schema itself.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 10:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 14:46 [PATCH v4 0/5] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-05-21 14:46 ` [PATCH v4 1/5] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-05-25 10:00 ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 2/5] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-05-25 10:00 ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 3/5] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-05-25 10:00 ` Claude review: " Claude Code Review Bot
2026-05-21 14:46 ` [PATCH v4 4/5] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-05-21 19:45 ` Conor Dooley
2026-05-21 20:24 ` Dmitry Baryshkov
2026-05-22 6:32 ` Neil Armstrong
2026-05-21 20:46 ` Rob Herring (Arm)
2026-05-25 10:00 ` Claude Code Review Bot [this message]
2026-05-21 14:46 ` [PATCH v4 5/5] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-05-25 10:00 ` Claude review: " Claude Code Review Bot
2026-05-25 10:00 ` Claude review: Add support to 2 panels in bonded-DSI mode Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260521-sm8650-7-1-bonded-dsi-v4-4-a4dd5e0850f1@linaro.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox