public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Create common PSP interfaces for AIE2 and AIE4
Date: Tue, 31 Mar 2026 17:05:09 +1000	[thread overview]
Message-ID: <review-patch3-20260330163705.3153647-4-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260330163705.3153647-4-lizhi.hou@amd.com>

Patch Review

Renames `aie2_psp.c` → `aie_psp.c` and moves PSP types/declarations into `aie.h`.

**Issue 1 — Copyright year change removes history:**
```c
-// Copyright (C) 2022-2024, Advanced Micro Devices, Inc.
+// Copyright (C) 2026, Advanced Micro Devices, Inc.
```
The original copyright range (2022-2024) is replaced with just 2026. This loses the attribution history. Should be `2022-2026`.

**Issue 2 — `psp_conf` zero-initialization:**
```c
-	struct psp_config psp_conf;
+	struct psp_config psp_conf = { 0 };
```
Good — needed because `psp_config` now has more fields (`certfw_buf`, `certfw_size`, `arg2_mask`, `notify_val`). But `arg2_mask` and `notify_val` are not set in this patch (they're added in patch 4), so `arg2_mask = 0` and `notify_val = 0` would be used if PSP runs before patch 4 is applied. This means the series has a bisection issue — patches 3 alone would break PSP because `notify_val = 0` means the interrupt never fires.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31  7:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 16:36 [PATCH V1 0/6] accel/amdxdna: Initial support for AIE4 platform Lizhi Hou
2026-03-30 16:37 ` [PATCH V1 1/6] accel/amdxdna: Create shared functions for AIE2 and AIE4 Lizhi Hou
2026-03-31  7:05   ` Claude review: " Claude Code Review Bot
2026-03-30 16:37 ` [PATCH V1 2/6] accel/amdxdna: Add basic support for AIE4 devices Lizhi Hou
2026-03-31  7:05   ` Claude review: " Claude Code Review Bot
2026-03-30 16:37 ` [PATCH V1 3/6] accel/amdxdna: Create common PSP interfaces for AIE2 and AIE4 Lizhi Hou
2026-03-31  7:05   ` Claude Code Review Bot [this message]
2026-03-30 16:37 ` [PATCH V1 4/6] accel/amdxdna: Add AIE4 firmware loading Lizhi Hou
2026-03-30 20:17   ` Mario Limonciello
2026-03-30 20:30     ` yidong Zhang
2026-03-31  2:45   ` Mario Limonciello
2026-03-31  7:05   ` Claude review: " Claude Code Review Bot
2026-03-30 16:37 ` [PATCH V1 5/6] accel/amdxdna: Create common SMU interfaces for AIE2 and AIE4 Lizhi Hou
2026-03-31  7:05   ` Claude review: " Claude Code Review Bot
2026-03-30 16:37 ` [PATCH V1 6/6] accel/amdxdna: Add AIE4 power on and off support Lizhi Hou
2026-03-31  7:05   ` Claude review: " Claude Code Review Bot
2026-03-31  7:05 ` Claude review: accel/amdxdna: Initial support for AIE4 platform Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260330163705.3153647-4-lizhi.hou@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox