From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: platform/surface: SAM: Add support for Surface Pro 12in
Date: Sat, 16 May 2026 09:57:52 +1000 [thread overview]
Message-ID: <review-patch3-ab458aadea651396d9ea7629419a32dc7510c593.1778822464.git.harrison.vanderbyl@gmail.com> (raw)
In-Reply-To: <ab458aadea651396d9ea7629419a32dc7510c593.1778822464.git.harrison.vanderbyl@gmail.com>
Patch Review
Adds a SAM node group and OF match entry for the Surface Pro 12in:
```c
+static const struct software_node *ssam_node_group_sp12in[] = {
+ &ssam_node_root,
+ &ssam_node_hub_kip,
+ &ssam_node_tmp_sensors,
+ &ssam_node_hid_kip_keyboard,
+ &ssam_node_hid_sam_penstash,
+ &ssam_node_hid_kip_touchpad,
+ &ssam_node_hid_kip_fwupd,
+ &ssam_node_pos_tablet_switch,
+ NULL,
+};
```
The commit message explains the deliberate omission of battery and charger info nodes to avoid conflicts with other drivers. The node group is similar to SP11 (`ssam_node_group_sp11`) but without battery-related nodes.
The OF match entry correctly uses the compatible from the DTS:
```c
+ { .compatible = "microsoft,surface-pro-12in", (void *)ssam_node_group_sp12in },
```
**Minor nit:** The comment says `/* Surface Pro 12in First Edition (ARM/QCOM) */` while other entries use shorter names like `/* Surface Pro 11 (ARM/QCOM) */`. Consistent, but "First Edition" is a bit verbose for a comment. Not blocking.
**No functional issues.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <177869930359.1496076.12020223802779537187.b4-ty@kernel.org>
2026-05-15 5:41 ` [PATCH v2 0/7] Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Harrison Vanderbyl
2026-05-15 5:41 ` [PATCH v2 1/7] dt-bindings: arm: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 7:03 ` Krzysztof Kozlowski
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 2/7] dt-bindings: crypto: Add x1e80100 inline crypto Harrison Vanderbyl
2026-05-15 7:04 ` Krzysztof Kozlowski
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 3/7] platform/surface: SAM: Add support for Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57 ` Claude Code Review Bot [this message]
2026-05-15 5:41 ` [PATCH v2 4/7] hid: Pen battery quirk " Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 5/7] drm/panel-edp: Add panel " Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 6/7] arm64: dts: qcom: hamoa: Add inline crypto for UFS Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 7/7] arm64: dts: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 23:57 ` Claude review: Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-ab458aadea651396d9ea7629419a32dc7510c593.1778822464.git.harrison.vanderbyl@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox