From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: hamoa: Add inline crypto for UFS
Date: Sat, 16 May 2026 09:57:53 +1000 [thread overview]
Message-ID: <review-patch6-30c12b79c6cc481afb13ac93630c5a16bc856ae4.1778822464.git.harrison.vanderbyl@gmail.com> (raw)
In-Reply-To: <30c12b79c6cc481afb13ac93630c5a16bc856ae4.1778822464.git.harrison.vanderbyl@gmail.com>
Patch Review
Adds the ICE node and wires it to the UFS host controller in the shared hamoa.dtsi:
```dts
+ ice: crypto@1d88000 {
+ compatible = "qcom,x1e80100-inline-crypto-engine",
+ "qcom,inline-crypto-engine";
+ reg = <0x0 0x01d88000 0x0 0x8000>;
+
+ clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+ };
```
The `qcom,ice` property is added to the UFS node:
```dts
+ qcom,ice = <&ice>;
```
The ICE node address `0x1d88000` is correctly placed before `cryptobam` at `0x1dc4000` in ascending address order. The compatible uses the binding from patch 2/7. This affects all hamoa-based boards (x1e80100 family), which is intentional since the ICE hardware is part of the SoC.
**Potential concern:** This change affects the shared `hamoa.dtsi` which is used by all x1e80100/x1p42100 boards. Adding `qcom,ice` to the UFS node and a new ICE device node will affect existing boards (Surface Pro 11 / Denali, Lenovo ThinkPad, ASUS VivoBook, etc.). This should be fine since the ICE hardware exists on all these SoCs — but it would be good to confirm this doesn't break any existing boards. The ICE node has no `status` property so it defaults to "okay", and the `qcom,ice` property in the UFS node is optional in the driver. This should be safe.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <177869930359.1496076.12020223802779537187.b4-ty@kernel.org>
2026-05-15 5:41 ` [PATCH v2 0/7] Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Harrison Vanderbyl
2026-05-15 5:41 ` [PATCH v2 1/7] dt-bindings: arm: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 7:03 ` Krzysztof Kozlowski
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 2/7] dt-bindings: crypto: Add x1e80100 inline crypto Harrison Vanderbyl
2026-05-15 7:04 ` Krzysztof Kozlowski
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 3/7] platform/surface: SAM: Add support for Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 4/7] hid: Pen battery quirk " Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 5/7] drm/panel-edp: Add panel " Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 5:41 ` [PATCH v2 6/7] arm64: dts: qcom: hamoa: Add inline crypto for UFS Harrison Vanderbyl
2026-05-15 23:57 ` Claude Code Review Bot [this message]
2026-05-15 5:41 ` [PATCH v2 7/7] arm64: dts: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57 ` Claude review: " Claude Code Review Bot
2026-05-15 23:57 ` Claude review: Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-30c12b79c6cc481afb13ac93630c5a16bc856ae4.1778822464.git.harrison.vanderbyl@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox