public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: hid: Pen battery quirk for Surface Pro 12in
Date: Sat, 16 May 2026 09:57:53 +1000	[thread overview]
Message-ID: <review-patch4-de275cc63e764d2acddf72bf3f50e89f307f41b5.1778822464.git.harrison.vanderbyl@gmail.com> (raw)
In-Reply-To: <de275cc63e764d2acddf72bf3f50e89f307f41b5.1778822464.git.harrison.vanderbyl@gmail.com>

Patch Review

Adds `HID_BATTERY_QUIRK_IGNORE` for the Elan touchscreen controller on this device:

```c
+#define I2C_DEVICE_ID_SURFACE_PRO_12IN  0x4376
```

```c
+	{ HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_SURFACE_PRO_12IN),
+	  HID_BATTERY_QUIRK_IGNORE },
```

The commit message explains the pen reports battery over Bluetooth, not I2C, so querying the I2C device for battery either shows a phantom battery or causes hangs. Using `HID_BATTERY_QUIRK_IGNORE` (not `AVOID_QUERY` like the Trogdor entry above it) is appropriate since the battery shouldn't be reported at all from this path.

Already Acked-by Jiri Kosina.

**Minor nit:** The `#define` uses two spaces before `0x4376` — other defines in hid-ids.h typically use a tab. This is cosmetic and likely fine.

**No functional issues.**

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 23:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <177869930359.1496076.12020223802779537187.b4-ty@kernel.org>
2026-05-15  5:41 ` [PATCH v2 0/7] Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Harrison Vanderbyl
2026-05-15  5:41   ` [PATCH v2 1/7] dt-bindings: arm: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15  7:03     ` Krzysztof Kozlowski
2026-05-15 23:57       ` Claude review: " Claude Code Review Bot
2026-05-15  5:41   ` [PATCH v2 2/7] dt-bindings: crypto: Add x1e80100 inline crypto Harrison Vanderbyl
2026-05-15  7:04     ` Krzysztof Kozlowski
2026-05-15 23:57       ` Claude review: " Claude Code Review Bot
2026-05-15  5:41   ` [PATCH v2 3/7] platform/surface: SAM: Add support for Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57     ` Claude review: " Claude Code Review Bot
2026-05-15  5:41   ` [PATCH v2 4/7] hid: Pen battery quirk " Harrison Vanderbyl
2026-05-15 23:57     ` Claude Code Review Bot [this message]
2026-05-15  5:41   ` [PATCH v2 5/7] drm/panel-edp: Add panel " Harrison Vanderbyl
2026-05-15 23:57     ` Claude review: " Claude Code Review Bot
2026-05-15  5:41   ` [PATCH v2 6/7] arm64: dts: qcom: hamoa: Add inline crypto for UFS Harrison Vanderbyl
2026-05-15 23:57     ` Claude review: " Claude Code Review Bot
2026-05-15  5:41   ` [PATCH v2 7/7] arm64: dts: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 23:57     ` Claude review: " Claude Code Review Bot
2026-05-15 23:57   ` Claude review: Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-de275cc63e764d2acddf72bf3f50e89f307f41b5.1778822464.git.harrison.vanderbyl@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox