From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/adreno: set cx_misc_mmio regardless of if platform has LLCC
Date: Sun, 12 Apr 2026 13:17:01 +1000 [thread overview]
Message-ID: <review-patch4-20260407-adreno-810-v3-4-30cb7f196ed4@pm.me> (raw)
In-Reply-To: <20260407-adreno-810-v3-4-30cb7f196ed4@pm.me>
Patch Review
This patch decouples the `cx_misc_mmio` mapping from LLCC slice availability. The key motivation is that Milos has no LLCC but still needs access to CX_MISC registers (for TCM retention, software fuses, etc.).
The approach is sound:
- MMU500 detection and `cx_misc_mmio` mapping are moved from `a6xx_llc_slices_init()` into `a6xx_gpu_init()`.
- The early-return guards in `a6xx_llc_activate()` and `a7xx_llc_activate()` are changed from checking `cx_misc_mmio` to checking whether LLC slices are available directly:
```c
- if (IS_ERR(a6xx_gpu->cx_misc_mmio))
+ if (IS_ERR_OR_NULL(a6xx_gpu->llc_slice) && IS_ERR_OR_NULL(a6xx_gpu->htw_llc_slice))
```
This is safe because `a7xx_llc_activate()` (the path used for A8xx) does not use `cx_misc_mmio` — it only writes GPU registers via `gpu_write()` and calls `llcc_slice_activate()`. The `a6xx_llc_activate()` path does use `cx_misc_mmio` but only inside the `if (!a6xx_gpu->have_mmu500)` block, and for platforms that reach that code, `cx_misc_mmio` will be mapped (since `!have_mmu500` is one of the conditions for mapping it).
Already has Reviewed-by from both Konrad Dybcio and Akhil P Oommen. Looks correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 1:45 [PATCH RFC v3 0/7] Add support for Adreno 810 GPU Alexander Koskovich
2026-04-08 1:45 ` [PATCH RFC v3 1/7] dt-bindings: display/msm/gmu: Document Adreno 810 GMU Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-08 1:45 ` [PATCH RFC v3 2/7] dt-bindings: display/msm/gpu: Document A810 GPU Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-08 1:45 ` [PATCH RFC v3 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-04-08 8:58 ` Konrad Dybcio
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-08 1:45 ` [PATCH RFC v3 4/7] drm/msm/adreno: set cx_misc_mmio regardless of if platform has LLCC Alexander Koskovich
2026-04-12 3:17 ` Claude Code Review Bot [this message]
2026-04-08 1:46 ` [PATCH RFC v3 5/7] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-08 1:46 ` [PATCH RFC v3 6/7] drm/msm/adreno: add Adreno 810 GPU support Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-08 1:46 ` [PATCH RFC v3 7/7] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
2026-04-12 3:17 ` Claude review: Add support for Adreno 810 GPU Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260407-adreno-810-v3-4-30cb7f196ed4@pm.me \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox