public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits
Date: Mon, 25 May 2026 22:39:45 +1000	[thread overview]
Message-ID: <review-patch4-20260519160825.4082566-5-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260519160825.4082566-5-prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch Review

**Status: Good**

Refactors the hardcoded pixel clock check into per-SoC `mode_clock_min`/`mode_clock_max` fields in `rzg2l_du_device_info`. The old code:

```c
if (renc->output == RZG2L_DU_OUTPUT_DPAD0 && mode->clock > 83500)
    return MODE_CLOCK_HIGH;
```

becomes a table-driven check with an early return for non-DPAD0 outputs:

```c
if (renc->output != RZG2L_DU_OUTPUT_DPAD0)
    return MODE_OK;

if (info->mode_clock_min && mode->clock < info->mode_clock_min)
    return MODE_CLOCK_LOW;
if (info->mode_clock_max && mode->clock > info->mode_clock_max)
    return MODE_CLOCK_HIGH;
```

The zero-check (`info->mode_clock_min &&`) means SoCs that don't set these fields (like `r9a09g057`) will skip validation, which is correct since that SoC uses DSI0 output only (no DPAD0 route) and the early return would catch it anyway.

Existing RZ/G2UL and RZ/G2L both get `mode_clock_min = 20875` and `mode_clock_max = 83500`, preserving the existing 83500 max and adding the previously missing minimum. The addition of the minimum check is a slight functional change but is reasonable as a correction.

The trailing comma fix on the `r9a07g044` struct is a nice bonus cleanup:
```c
-	}
+	},
```

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25 12:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 16:08 [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-19 16:08 ` [PATCH v4 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 4/5] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-20  5:35   ` Biju Das
2026-05-20  8:13     ` Lad, Prabhakar
2026-05-20  8:15       ` Biju Das
2026-05-22  6:27         ` Biju Das
2026-05-25 12:39   ` Claude Code Review Bot [this message]
2026-05-19 16:08 ` [PATCH v4 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-22  7:43 ` [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Biju Das
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-29 17:00 [PATCH 0/4] " Prabhakar
2026-04-29 17:00 ` [PATCH 3/4] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-05  1:22   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260519160825.4082566-5-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox