From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support
Date: Mon, 25 May 2026 22:39:44 +1000 [thread overview]
Message-ID: <review-patch3-20260519160825.4082566-4-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260519160825.4082566-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
Patch Review
**Status: Good, minor nit**
Switches from `devm_reset_control_get_shared()` to `devm_reset_control_get_optional_shared()`. The existing error handling still works correctly since `_optional` returns NULL instead of an error when no reset is present, and `reset_control_assert()`/`reset_control_deassert()` are documented to be no-ops on NULL.
Minor nit: the error message `"can't get cpg reset\n"` will now only trigger for actual errors (not -ENOENT), but it might be slightly confusing since on RZ/T2H there's intentionally no reset. However, the `_optional` variant returns NULL for absent resets rather than an error, so this path only fires on genuine failures. This is fine.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 12:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 16:08 [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-19 16:08 ` [PATCH v4 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-25 12:39 ` Claude Code Review Bot [this message]
2026-05-19 16:08 ` [PATCH v4 4/5] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-20 5:35 ` Biju Das
2026-05-20 8:13 ` Lad, Prabhakar
2026-05-20 8:15 ` Biju Das
2026-05-22 6:27 ` Biju Das
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
2026-05-22 7:43 ` [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Biju Das
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 14:40 [PATCH v3 0/5] " Prabhakar
2026-05-12 14:41 ` [PATCH v3 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-16 3:13 ` Claude review: " Claude Code Review Bot
2026-04-29 17:00 [PATCH 0/4] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-04-29 17:00 ` [PATCH 2/4] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-05 1:22 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260519160825.4082566-4-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox