public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support
Date: Mon, 25 May 2026 22:39:44 +1000	[thread overview]
Message-ID: <review-patch2-20260519160825.4082566-3-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260519160825.4082566-3-prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch Review

**Status: Good, one minor observation**

Adds the new compatible strings and handles the structural differences:
- `renesas,r9a09g077-du` for RZ/T2H
- `renesas,r9a09g087-du` for RZ/N2H (with RZ/T2H as fallback)

The binding groups RZ/T2H with RZ/G2UL for the single-port constraint, which makes sense since both only support port@0 DPI:

```yaml
            enum:
              - renesas,r9a07g043u-du
              - renesas,r9a09g077-du
```

The `resets` handling is well done — making it conditional via `if/then/else`:

```yaml
  - if:
      properties:
        compatible:
          contains:
            const: renesas,r9a09g077-du
    then:
      properties:
        resets: false
    else:
      required:
        - resets
```

One observation: the `resets` property is removed from the top-level `required` list and made conditionally required via the `else` clause. This means any *future* SoC added to the binding without updating this `if/else` block would also get `resets` required, which is the safe default. Good design.

Note that patch 2 arrived out of order in the mbox (the mbox has it as the second message but with subject line "2/5" while the "3/5" patch arrived before it). This is just a mail delivery ordering artifact and doesn't affect the patches themselves.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 12:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 16:08 [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-19 16:08 ` [PATCH v4 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-25 12:39   ` Claude Code Review Bot [this message]
2026-05-19 16:08 ` [PATCH v4 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 4/5] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-20  5:35   ` Biju Das
2026-05-20  8:13     ` Lad, Prabhakar
2026-05-20  8:15       ` Biju Das
2026-05-22  6:27         ` Biju Das
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-22  7:43 ` [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Biju Das
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 14:40 [PATCH v3 0/5] " Prabhakar
2026-05-12 14:41 ` [PATCH v3 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-04-29 17:00 [PATCH 0/4] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-04-29 17:00 ` [PATCH 1/4] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-05  1:22   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260519160825.4082566-3-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox