public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Add support for RZ/T2H SoC
Date: Mon, 25 May 2026 22:39:45 +1000	[thread overview]
Message-ID: <review-patch5-20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch Review

**Status: Good**

Adds the actual RZ/T2H support. Key additions:

1. **Feature flag infrastructure** — `RZG2L_DU_FEATURE_DPIO_OE` and the `rzg2l_du_has()` helper. The helper is clean:
```c
static inline bool rzg2l_du_has(struct rzg2l_du_device *rcdu,
                unsigned int feature)
{
    return rcdu->info->features & feature;
}
```

2. **DPI output enable** — In `rzg2l_du_start_stop()`, the RZ/T2H variant additionally asserts `DU_MCR0_DPI_EN` (BIT(0)):
```c
u32 val = DU_MCR0_DI_EN;

if (start && rzg2l_du_has(rcdu, RZG2L_DU_FEATURE_DPIO_OE))
    val |= DU_MCR0_DPI_EN;

writel(start ? val : 0, rcdu->mmio + DU_MCR0);
```

This correctly only sets `DPI_EN` when starting, and writes 0 when stopping (clearing both bits).

3. **Device info** for the new SoC with clock limits 5000–100000 kHz (wider than RZ/G2UL/G2L).

The `features` field is added to the struct doc comment in `rzg2l_du_drv.h`, which is good.

One thing to note: the patch series does not add the `r9a09g087` (RZ/N2H) compatible to the `of_device_id` table in the driver. This is fine since the DT binding specifies `renesas,r9a09g077-du` as the fallback for RZ/N2H, so the kernel will match on the RZ/T2H compatible. This is the standard Renesas pattern for compatible SoC variants.

**Overall verdict: The series looks ready to merge.** It's well-reviewed, follows established patterns, and the changes are correct and minimal.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 12:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 16:08 [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-19 16:08 ` [PATCH v4 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 4/5] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-20  5:35   ` Biju Das
2026-05-20  8:13     ` Lad, Prabhakar
2026-05-20  8:15       ` Biju Das
2026-05-22  6:27         ` Biju Das
2026-05-25 12:39   ` Claude review: " Claude Code Review Bot
2026-05-19 16:08 ` [PATCH v4 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-25 12:39   ` Claude Code Review Bot [this message]
2026-05-22  7:43 ` [PATCH v4 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Biju Das
2026-05-25 12:39 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 14:40 [PATCH v3 0/5] " Prabhakar
2026-05-12 14:41 ` [PATCH v3 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-04-29 17:00 [PATCH 0/4] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-04-29 17:00 ` [PATCH 4/4] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-05  1:22   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox