From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run()
Date: Tue, 28 Apr 2026 15:01:47 +1000 [thread overview]
Message-ID: <review-patch5-20260427-nova-unload-v4-5-e145ccddae66@nvidia.com> (raw)
In-Reply-To: <20260427-nova-unload-v4-5-e145ccddae66@nvidia.com>
Patch Review
This moves the SEC2 reset/load/boot sequence from inline code in `boot()` into `BooterFirmware::run()`. The refactoring also creates a `run_booter()` helper on `Gsp`.
One small difference between old and new code: the old code used `dev_dbg!(pdev, ...)` while the new `BooterFirmware::run()` uses `dev_dbg!(dev, ...)`. Both resolve to the same device, since `pdev.as_ref()` gives the device, but the log source device type differs slightly. This is cosmetic.
The `BooterFirmware::run()` takes a generic `wpr_meta: &Coherent<T>` — this is good since it only needs the DMA handle, not the specific type.
The BooterFirmware construction is also separated from use — previously it was constructed early and used late. Now with `run_booter()`, construction and execution are together. This is cleaner.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 5:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:56 [PATCH v4 0/8] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-04-27 6:56 ` [PATCH v4 1/8] gpu: nova-core: remove unneeded get_gsp_info proxy function Alexandre Courbot
2026-04-27 13:16 ` Gary Guo
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:56 ` [PATCH v4 2/8] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:57 ` [PATCH v4 3/8] gpu: nova-core: split BAR acquisition in unbind() Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:57 ` [PATCH v4 4/8] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:57 ` [PATCH v4 5/8] gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run() Alexandre Courbot
2026-04-28 5:01 ` Claude Code Review Bot [this message]
2026-04-27 6:57 ` [PATCH v4 6/8] gpu: nova-core: gsp: shuffle boot code a bit to keep chipset-specific parts close Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:57 ` [PATCH v4 7/8] gpu: nova-core: gsp: move chipset-specific parts of the boot process into a HAL Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-27 6:57 ` [PATCH v4 8/8] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-28 5:01 ` Claude review: gpu: nova-core: run unload sequence " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260427-nova-unload-v4-5-e145ccddae66@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox