public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: Add GPU support for Glymur
Date: Sat, 16 May 2026 12:51:47 +1000	[thread overview]
Message-ID: <review-patch5-20260513-glymur-gpu-dt-v4-5-f83832c3bc9a@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-glymur-gpu-dt-v4-5-f83832c3bc9a@oss.qualcomm.com>

Patch Review

Adds the GPU node (`gpu@3d00000`) and GMU node (`gmu@3d6c000`).

**GPU node:**
- `reg` has 2 entries matching the binding: `kgsl_3d0_reg_memory` at `0x03d00000` (size `0x6c000`) and `cx_mem` at `0x03d9e000` (size `0x2000`)
- 12 OPP entries from 310 MHz to 1850 MHz with appropriate voltage levels
- `#cooling-cells = <2>` for thermal integration (used by patch 6)
- Interconnect to DDR via `hsc_noc`/`mc_virt`
- Two IOMMU entries (SIDs 0 and 1)

**GMU node:**
- 6 clocks (ahb, gmu, cxo, memnoc, hub, rscc)
- CX and GX power domains
- 4 OPP entries from 575 MHz to 750 MHz
- IOMMU SID 5

**Address range verification:**
- GPU: `0x03d00000 - 0x03d6bfff` — no overlap with GMU (`0x03d6c000`)
- gxclkctl (`0x03d64000 - 0x03d69fff`) is a sub-block within GPU register space, which is expected
- cx_mem (`0x03d9e000`) starts exactly where GMU ends (`0x03d6c000 + 0x32000 = 0x03d9e000`) — no overlap

Node ordering follows address order correctly (gpu before gxclkctl before gmu before gpucc).

The top two OPPs (1550 MHz and 1700 MHz) have `opp-supported-hw = <0x7>` and the highest (1850 MHz) has `<0x3>`, meaning they're only available on certain speed bins. This is standard practice.

No issues found.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 19:21 [PATCH v4 0/6] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 1/6] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 2/6] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-14 10:13   ` Krzysztof Kozlowski
2026-05-15 22:15     ` Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 3/6] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-14 10:14   ` Krzysztof Kozlowski
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 4/6] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 5/6] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  2:51   ` Claude Code Review Bot [this message]
2026-05-12 19:21 ` [PATCH v4 6/6] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-16  2:51 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 20:06 [PATCH v3 0/5] " Akhil P Oommen
2026-05-11 20:07 ` [PATCH v3 5/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260513-glymur-gpu-dt-v4-5-f83832c3bc9a@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox