public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a8xx: Fix RSCC offset
Date: Sat, 16 May 2026 12:51:46 +1000	[thread overview]
Message-ID: <review-patch1-20260513-glymur-gpu-dt-v4-1-f83832c3bc9a@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-glymur-gpu-dt-v4-1-f83832c3bc9a@oss.qualcomm.com>

Patch Review

**Purpose:** Changes the RSCC base from `gmu->mmio + 0x19000` (GMU-relative) to `gpu->mmio + 0x50000` (GPU-relative) for A8xx GPUs.

This fix looks correct. Based on the Glymur DT in patch 5, the GPU register space covers `0x03d00000` (size `0x6c000`) and GMU is at `0x03d6c000`. The old code pointed RSCC at `0x03d85000` (GMU+0x19000), while the fix targets `0x03d50000` (GPU+0x50000), which falls squarely within the GPU's `kgsl_3d0_reg_memory` range. The `gpu` local variable is already initialized at line 2236 of `a6xx_gmu.c` and its `mmio` is mapped before GMU init, so this is safe.

The cleanup path in `a6xx_gmu_remove()` sets `gmu->rscc = NULL` without trying to iounmap it separately, which is correct since it's now an offset into `gpu->mmio`.

**Minor nit:** The comment has a typo — extra space before the comma:

```c
 * On a8xx , RSCC lives at GPU base + 0x50000, which falls
```

Should be:

```c
 * On a8xx, RSCC lives at GPU base + 0x50000, which falls
```

The Fixes tag pointing to `50e8a557d8d3 ("drm/msm/a8xx: Add support for A8x GMU")` is appropriate.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 19:21 [PATCH v4 0/6] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 1/6] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-16  2:51   ` Claude Code Review Bot [this message]
2026-05-12 19:21 ` [PATCH v4 2/6] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-14 10:13   ` Krzysztof Kozlowski
2026-05-15 22:15     ` Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 3/6] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-14 10:14   ` Krzysztof Kozlowski
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 4/6] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 5/6] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 6/6] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-16  2:51 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 20:06 [PATCH v3 0/5] " Akhil P Oommen
2026-05-11 20:06 ` [PATCH v3 1/5] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260513-glymur-gpu-dt-v4-1-f83832c3bc9a@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox