public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: glymur: Add GPU cooling
Date: Sat, 16 May 2026 12:51:48 +1000	[thread overview]
Message-ID: <review-patch6-20260513-glymur-gpu-dt-v4-6-f83832c3bc9a@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-glymur-gpu-dt-v4-6-f83832c3bc9a@oss.qualcomm.com>

Patch Review

Adds passive thermal throttling to all 14 GPU thermal zones (gpu-0-0 through gpu-3-2, plus gpuss-0 and gpuss-1). For each zone:
- Adds `polling-delay-passive = <100>` (100ms polling when throttling)
- Changes trip type from `"hot"` to `"passive"` (enables throttling)
- Raises trip temperature from 90°C to 95°C
- Reduces hysteresis from 5°C to 1°C
- Adds cooling-map linking to the `&gpu` cooling device

The `#include <dt-bindings/thermal/thermal.h>` is correctly added for `THERMAL_NO_LIMIT`.

**Observation:** In the first thermal zone (`gpu-0-0-thermal`), the diff shows the `cooling-maps` block is placed before `trips`, while the closing `};` for the zone gets an extra blank line added before it. This is cosmetic but slightly inconsistent with the original formatting. Not a blocker.

The pattern is consistent across all 14 zones. Raising the threshold from 90°C to 95°C while switching to passive (throttling) cooling is a reasonable tradeoff — the GPU throttles itself at 95°C rather than just logging at 90°C. The 1°C hysteresis (down from 5°C) means the GPU will start ramping back up more quickly once temperature drops below 94°C, which is appropriate for passive throttling.

No functional issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 19:21 [PATCH v4 0/6] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 1/6] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 2/6] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-14 10:13   ` Krzysztof Kozlowski
2026-05-15 22:15     ` Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 3/6] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-14 10:14   ` Krzysztof Kozlowski
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 4/6] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 5/6] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-12 19:21 ` [PATCH v4 6/6] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-16  2:51   ` Claude Code Review Bot [this message]
2026-05-16  2:51 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260513-glymur-gpu-dt-v4-6-f83832c3bc9a@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox