public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: Add GPU support for Glymur
Date: Sat, 16 May 2026 14:42:43 +1000	[thread overview]
Message-ID: <review-patch5-20260512-glymur-gpu-dt-v3-5-84232dc21c03@oss.qualcomm.com> (raw)
In-Reply-To: <20260512-glymur-gpu-dt-v3-5-84232dc21c03@oss.qualcomm.com>

Patch Review

**Change:** Adds the `gpu@3d00000` and `gmu@3d6c000` nodes to glymur.dtsi.

**GPU node (`gpu@3d00000`):**
- Compatible: `"qcom,adreno-44070001", "qcom,adreno"` -- matches catalog
- reg: `kgsl_3d0_reg_memory` at 0x3d00000 size 0x6c000, `cx_mem` at 0x3d9e000 size 0x2000 -- matches the 2-reg constraint from patch 2
- The kgsl_3d0_reg_memory range (0x3d00000 - 0x3d6c000) encompasses the RSCC at 0x3d50000 (gpu base + 0x50000 from patch 1), which is consistent
- 12 OPP entries from 310MHz to 1850MHz, with ACD disabled on the two lowest frequencies
- The highest OPPs (1550/1700/1850 MHz) have progressively restricted `opp-supported-hw` masks (0x7, 0x7, 0x3), consistent with speedbin support in the catalog
- interconnects properly reference `hsc_noc` and `mc_virt`

**GMU node (`gmu@3d6c000`):**
- Compatible: `"qcom,adreno-gmu-x285.1", "qcom,adreno-gmu"`
- reg: single "gmu" region at 0x3d6c000, size 0x32000
- 6 clocks including `rscc` clock -- note this is a new clock compared to some other GMU nodes
- Power domains: CX from gpucc, GX from gxclkctl
- 4 GMU OPP entries from 575MHz to 750MHz

**Node ordering:** `gpu@3d00000` is inserted before `gxclkctl@3d64000`, and `gmu@3d6c000` is inserted after `gxclkctl` and before `gpucc@3d90000`. This maintains ascending address order.

**Address overlap note:** The GPU kgsl_3d0_reg_memory range (0x3d00000-0x3d6c000) physically encompasses the gxclkctl range (0x3d64000-0x3d6a000). Similarly, the GMU range (0x3d6c000-0x3d9e000) encompasses gpucc (0x3d90000-0x3d99800). These overlaps are typical of Qualcomm SoCs where sub-blocks are carved from larger address regions and managed by different drivers. Not a problem.

**Verdict:** Looks correct and well-structured.

---

### Summary

The series is in good shape. Two items to address before merging:

1. **Patch 3**: The commit message is stale -- it references adding an `interconnects` property that was actually removed in v3. Needs a reword.
2. **Patch 1**: Minor cosmetic -- extra space before comma in the comment (`On a8xx ,`). Also could benefit from clarifying in the commit message whether this fixes a real regression on existing A8xx hardware or is fixing not-yet-exercised code.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  4:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 20:06 [PATCH v3 0/5] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-11 20:06 ` [PATCH v3 1/5] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-11 20:58   ` Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 2/5] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 3/5] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 4/5] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 5/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  4:42   ` Claude Code Review Bot [this message]
2026-05-16  4:42 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 19:21 [PATCH v4 0/6] " Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 5/6] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260512-glymur-gpu-dt-v3-5-84232dc21c03@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox