From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU
Date: Sat, 16 May 2026 14:42:42 +1000 [thread overview]
Message-ID: <review-patch3-20260512-glymur-gpu-dt-v3-3-84232dc21c03@oss.qualcomm.com> (raw)
In-Reply-To: <20260512-glymur-gpu-dt-v3-3-84232dc21c03@oss.qualcomm.com>
Patch Review
**Change:** Extends the `qcom,sm8750-smmu-500` binding block to also cover `qcom,glymur-smmu-500` by converting the `const` to an `enum`.
This makes sense -- Glymur uses the same single "hlos" vote clock as sm8750. The YAML change is structurally correct: replacing `- const: qcom,sm8750-smmu-500` with a 2-element enum preserving sort order.
**Observation:** The commit message says "Add the interconnects property to the common SMMU properties" but the diff doesn't add any interconnects property -- that was apparently dropped per the v3 changelog ("Remove interconnect property from adreno smmu dt and the binding doc"). The commit message needs updating to match the actual change.
**Verdict:** The code change is correct but the **commit message is stale/misleading** -- it describes v2 content that was removed. Should be updated to something like "Extend the sm8750 GPU SMMU clock constraints to also cover Glymur, which uses the same single 'hlos' vote clock."
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 20:06 [PATCH v3 0/5] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-11 20:06 ` [PATCH v3 1/5] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-11 20:58 ` Akhil P Oommen
2026-05-16 4:42 ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 2/5] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-16 4:42 ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 3/5] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-16 4:42 ` Claude Code Review Bot [this message]
2026-05-11 20:07 ` [PATCH v3 4/5] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-16 4:42 ` Claude review: " Claude Code Review Bot
2026-05-11 20:07 ` [PATCH v3 5/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16 4:42 ` Claude review: " Claude Code Review Bot
2026-05-16 4:42 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 19:21 [PATCH v4 0/6] " Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 3/6] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-16 2:51 ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 2/4] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-04 23:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260512-glymur-gpu-dt-v3-3-84232dc21c03@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox