From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: glymur: Add GPU cooling
Date: Mon, 25 May 2026 18:58:51 +1000 [thread overview]
Message-ID: <review-patch5-20260522-glymur-gpu-dt-v5-5-562c406b210c@oss.qualcomm.com> (raw)
In-Reply-To: <20260522-glymur-gpu-dt-v5-5-562c406b210c@oss.qualcomm.com>
Patch Review
**Summary:** Converts all 14 GPU thermal zones from stub "hot" trip points at 90°C to active "passive" cooling at 95°C with 1°C hysteresis and 100ms polling, all referencing the GPU device as a cooling device.
The changes are mechanically consistent across all 14 zones:
- Adds `polling-delay-passive = <100>` for 100ms polling during thermal mitigation.
- Adds `cooling-maps` referencing `<&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>`.
- Changes trip type from `"hot"` to `"passive"` to enable kernel-driven frequency throttling.
- Temperature raised from 90°C to 95°C, hysteresis reduced from 5°C to 1°C.
- Adds `#include <dt-bindings/thermal/thermal.h>` for `THERMAL_NO_LIMIT`.
- Critical trip points remain unchanged at 115°C.
The `cooling-maps` nodes are placed before `trips` in each thermal zone. The DT binding for thermal zones doesn't mandate ordering, so this is fine, though it's slightly unconventional (most existing DTs put `trips` first). Not a blocker.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 10:11 [PATCH v5 0/5] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-22 10:11 ` [PATCH v5 1/5] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-25 8:58 ` Claude review: " Claude Code Review Bot
2026-05-22 10:11 ` [PATCH v5 2/5] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-25 8:58 ` Claude review: " Claude Code Review Bot
2026-05-22 10:11 ` [PATCH v5 3/5] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-25 8:58 ` Claude review: " Claude Code Review Bot
2026-05-22 10:12 ` [PATCH v5 4/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-25 8:58 ` Claude review: " Claude Code Review Bot
2026-05-22 10:12 ` [PATCH v5 5/5] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-25 8:58 ` Claude Code Review Bot [this message]
2026-05-25 8:58 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 19:21 [PATCH v4 0/6] " Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 6/6] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-16 2:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260522-glymur-gpu-dt-v5-5-562c406b210c@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox