public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: Add GPU support for Glymur
Date: Mon, 25 May 2026 18:58:50 +1000	[thread overview]
Message-ID: <review-patch4-20260522-glymur-gpu-dt-v5-4-562c406b210c@oss.qualcomm.com> (raw)
In-Reply-To: <20260522-glymur-gpu-dt-v5-4-562c406b210c@oss.qualcomm.com>

Patch Review

**Summary:** Adds the GPU and GMU DT nodes with OPP tables, interconnects, and IOMMU references.

The GPU node at `0x3d00000` (size `0x6c000`) and GMU at `0x3d6c000` (size `0x32000`) are contiguous and non-overlapping:
- GPU: `0x3d00000` – `0x3d6bfff`
- GMU: `0x3d6c000` – `0x3d9dfff`
- cx_mem: `0x3d9e000` – `0x3d9ffff`

The RSCC at `gpu_base + 0x50000 = 0x3d50000` falls within the GPU kgsl_3d0_reg_memory range, consistent with patch 1.

The GPU OPP table has 12 entries ranging from 310 MHz to 1850 MHz (the cover letter's claimed max Fmax). The higher OPPs (1550+ MHz) use `opp-supported-hw = <0x7>` and `<0x3>` to restrict to specific speedbins — this is standard practice.

The GMU OPP table has 4 entries (575–750 MHz), which is reasonable.

**Observation:** The GMU register range (`0x3d6c000`, size `0x32000`, ending at `0x3d9dfff`) overlaps with `gpucc` at `0x3d90000` (size `0x9800`). This is likely intentional — the GMU driver only accesses its own registers within this range, and the clock controller has a separate ioremap. This pattern appears in other Qualcomm SoCs. Mentioned for completeness only.

Already has Reviewed-by from Konrad Dybcio.

No blocking issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  8:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 10:11 [PATCH v5 0/5] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-22 10:11 ` [PATCH v5 1/5] drm/msm/a8xx: Fix RSCC offset Akhil P Oommen
2026-05-25  8:58   ` Claude review: " Claude Code Review Bot
2026-05-22 10:11 ` [PATCH v5 2/5] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-25  8:58   ` Claude review: " Claude Code Review Bot
2026-05-22 10:11 ` [PATCH v5 3/5] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-25  8:58   ` Claude review: " Claude Code Review Bot
2026-05-22 10:12 ` [PATCH v5 4/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-25  8:58   ` Claude Code Review Bot [this message]
2026-05-22 10:12 ` [PATCH v5 5/5] arm64: dts: qcom: glymur: Add GPU cooling Akhil P Oommen
2026-05-25  8:58   ` Claude review: " Claude Code Review Bot
2026-05-25  8:58 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 19:21 [PATCH v4 0/6] " Akhil P Oommen
2026-05-12 19:21 ` [PATCH v4 5/6] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  2:51   ` Claude review: " Claude Code Review Bot
2026-05-11 20:06 [PATCH v3 0/5] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-11 20:07 ` [PATCH v3 5/5] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-16  4:42   ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260522-glymur-gpu-dt-v5-4-562c406b210c@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox