public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Use a local iomem base for PWR registers
Date: Tue, 28 Apr 2026 14:28:33 +1000	[thread overview]
Message-ID: <review-patch6-20260427155934.416502-7-karunika.choo@arm.com> (raw)
In-Reply-To: <20260427155934.416502-7-karunika.choo@arm.com>

Patch Review

Adds `pwr->iomem = ptdev->iomem + PWR_CONTROL_BASE`. Converts all PWR register accesses. The `PWR_CTRL_REG()` macro is removed and all PWR register offsets become relative to the block base.

**Minor**: The commit message has a typo: "PWR_CONTROl-local" (lowercase 'l' in CONTROL).

**Note**: This patch is missing Reviewed-by/Acked-by tags (only has Signed-off-by), presumably because it was significantly reworked in v3.

**Pre-existing issue** (not introduced by this series): In `panthor_pwr_l2_power_on()`:
```c
const u32 pwr_status = gpu_read64(pwr->iomem, PWR_STATUS);
const u32 l2_allow_mask = PWR_STATUS_DOMAIN_ALLOWED(PWR_COMMAND_DOMAIN_L2);
```
Both are `u32` but `PWR_STATUS` is a 64-bit register and `PWR_STATUS_DOMAIN_ALLOWED()` uses `BIT_U64()`. The truncation happens to be harmless for the L2 domain (bit 0), but should probably be `u64` for correctness. Not something this series needs to fix, but worth noting.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-28  4:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 15:59 [PATCH v3 0/8] drm/panthor: Localize register access by component Karunika Choo
2026-04-27 15:59 ` [PATCH v3 1/8] drm/panthor: Pass an iomem pointer to GPU register access helpers Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 2/8] drm/panthor: Split register definitions by components Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 3/8] drm/panthor: Replace cross-component register accesses with helpers Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 4/8] drm/panthor: Store IRQ register base iomem pointer in panthor_irq Karunika Choo
2026-04-27 17:34   ` Liviu Dudau
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 5/8] drm/panthor: Use a local iomem base for GPU registers Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-27 17:37   ` Liviu Dudau
2026-04-28  4:28   ` Claude Code Review Bot [this message]
2026-04-27 15:59 ` [PATCH v3 7/8] drm/panthor: Use a local iomem base for firmware control registers Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-27 15:59 ` [PATCH v3 8/8] drm/panthor: Use a local iomem base for MMU AS registers Karunika Choo
2026-04-28  4:28   ` Claude review: " Claude Code Review Bot
2026-04-28  4:28 ` Claude review: drm/panthor: Localize register access by component Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-12 14:29 [PATCH v2 0/8] " Karunika Choo
2026-04-12 14:29 ` [PATCH v2 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 [PATCH 0/8] drm/panthor: Localize register access by component Karunika Choo
2026-04-10 16:46 ` [PATCH 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260427155934.416502-7-karunika.choo@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox