[PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[Rosen Penev]

dcss_scaler_gaussian_filter() was missing @phase0_identity and
dcss_scaler_filter_design() was missing @phase0_identity and
@nn_interpolation in their kernel-doc comments.

Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 32c3f46b21da..e48b3117efb9 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
  * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
  * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
  * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output filter coefficients
  */
 static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
  * @src_length: length of input
  * @dst_length: length of output
  * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
  */
 static void dcss_scaler_filter_design(int src_length, int dst_length,
 				      bool use_5_taps, bool phase0_identity,
--
2.54.0

Re: [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[Laurentiu Palcu]

Hi,

There was already a fix sent for this:
https://lore.kernel.org/all/20260406180013.2442096-1-yiconghui@gmail.com/

On Sat, May 30, 2026 at 12:59:25PM -0700, Rosen Penev wrote:
> dcss_scaler_gaussian_filter() was missing @phase0_identity and
> dcss_scaler_filter_design() was missing @phase0_identity and
> @nn_interpolation in their kernel-doc comments.
> 
> Assisted-by: Opencode:Big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index 32c3f46b21da..e48b3117efb9 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -166,6 +166,7 @@ static int exp_approx_q(int x)
>   * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
>   * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
>   * @use_5_taps: indicates whether to use 5 taps or 7 taps
> + * @phase0_identity: use identity filter for phase 0
>   * @coef: output filter coefficients
>   */
>  static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> @@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
>   * @src_length: length of input
>   * @dst_length: length of output
>   * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
> + * @phase0_identity: use identity filter for phase 0
>   * @coef: output coefficients
> + * @nn_interpolation: use nearest neighbor interpolation
>   */
>  static void dcss_scaler_filter_design(int src_length, int dst_length,
>  				      bool use_5_taps, bool phase0_identity,
> --
> 2.54.0
> 

-- 
Thanks,
Laurentiu

Claude review: drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[Claude Code Review Bot]

Overall Series Review

Subject: drm/imx/dcss: add missing kernel-doc parameters for scaler functions
Author: Rosen Penev <rosenp@gmail.com>
Patches: 2
Reviewed: 2026-06-04T15:09:58.074333

---

This is a single-patch series that adds missing kernel-doc parameter descriptions for two static functions in the i.MX DCSS scaler driver. The patch is **correct and straightforward** — both `@phase0_identity` and `@nn_interpolation` are real parameters that were missing from the doc comments, and the descriptions are accurate.

One minor ordering issue exists: the `@nn_interpolation` entry is placed before the closing `*/` but after `@coef` in `dcss_scaler_filter_design()`, while in the actual function signature `coef` comes before `nn_interpolation`. This means the doc parameter order matches the signature order, which is correct.

The patch is trivially correct documentation fix and should be safe to apply.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/imx/dcss: add missing kernel-doc parameters for scaler functions

[Claude Code Review Bot]

Patch Review

**Correctness: Good.** Both additions match the actual function signatures.

For `dcss_scaler_gaussian_filter()` (line 171–173 of `dcss-scaler.c`):
```c
static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
					bool phase0_identity,
					int coef[][PSC_NUM_TAPS])
```
The parameter `phase0_identity` was indeed undocumented and sits between `use_5_taps` and `coef`. The patch correctly inserts `@phase0_identity` in the right position:
```
+ * @phase0_identity: use identity filter for phase 0
```

For `dcss_scaler_filter_design()` (lines 267–270):
```c
static void dcss_scaler_filter_design(int src_length, int dst_length,
				      bool use_5_taps, bool phase0_identity,
				      int coef[][PSC_NUM_TAPS],
				      bool nn_interpolation)
```
Both `phase0_identity` and `nn_interpolation` were missing. The patch adds them in the correct order matching the function signature:
```
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
```

**Minor nit:** The `Assisted-by:` tag in the commit message (`Assisted-by: Opencode:Big-pickle`) is not a standard kernel tag. The kernel community does not have a formally accepted `Assisted-by:` trailer. If this is intended to credit AI assistance, there's currently no agreed-upon convention for this in the kernel. Maintainers may want the author to drop this tag or use a different approach per subsystem policy.

**Verdict:** Trivially correct doc fix. No functional code changes. Looks good to apply, modulo the non-standard tag question.

---
Generated by Claude Code Patch Reviewer