public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 00/26] Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM
Date: Wed,  8 Apr 2026 14:12:12 +0530	[thread overview]
Message-ID: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> (raw)

Enable Adaptive Sync SDP for Panel replay + auxless ALPM.
First few patches are fixes in existing AS SDP enablement and drm core
changes for Panel replay with SDP.
Later patches add the support to send AS SDP for Panel replay with Link
ON and with auxless ALPM (Link-Off). 

This series is in continuation from discussions in [1] [2] [3]
and is actually revision 5 of the series [4].

While sending patches Rev 3 of [4], patchwork encountered an issue and
somehow dropped few patches from the series, and created new patchwork
links with incomplete list of patches for rev 3 and 4. With this CI couldnt
pick up the series for testing.

To avoid further confusion and more patchwork links with missing patches,
I am modifying the subject of the series to create new 'final' patchwork
link (with a hope that patchwork doesn't miss anymore patches) for which
we can get the CI results.

As the first few drm core changes get reviews, I intend to send those
separately and get them merge next.

[1] https://lore.kernel.org/all/1b8c6c6de1e5fe0db83e6ae942dfee7e6f950767.camel@intel.com/
[2] https://lore.kernel.org/all/aPtqdAxDwiuQZbrn@intel.com/
[3] https://lore.kernel.org/intel-gfx/7c2d6f4e-69e6-452a-89cc-5fd4254430bd@intel.com/T/#m6e8beab2cc3b6ff9d61f740f107d83a2f4e08114
[4] https://patchwork.freedesktop.org/series/161977/#rev2

Changes from last revision of Series [4]
 - Add helper to print SDP version in the logs and use it.
 - Fill missing sdp_type field in AS SDP unpack.
 - Check PR support also in helper
   intel_psr_pr_async_video_timing_supported()
 - Add #TODO to check Display ID 2.0 blocks for AS SDP for determining
   AS SDP v2 support.
 - Check if PR is enabled along with AS SDP enable before setting
   relevant Downspread CTRL DPCD bits.

Ankit Nautiyal (26):
  drm/dp: Rename and relocate AS SDP payload field masks
  drm/dp: Clean up DPRX feature enumeration macros
  drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support
  drm/dp: Add DPCD for configuring AS SDP for PR + VRR
  drm/dp: Store coasting vtotal in struct drm_dp_as_sdp
  drm/dp: Add a helper to get the SDP type as a string
  drm/dp: Add target_rr_divider field in AS SDP logging
  drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP
  drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink
  drm/i915/dp: Account for AS_SDP guardband only when enabled
  drm/i915/dp: Add a helper to decide if AS SDP can be used
  drm/i915/dp: Skip AS SDP for DP branch devices
  drm/i915/dp: Use revision field of AS SDP data structure
  drm/i915/dp: Set sdp_type in AS SDP unpack
  drm/i915/dp: Include all relevant AS SDP fields in comparison
  drm/i915/psr: Add helper to get Async Video timing support in PR
    active
  drm/i915/dp: Add member to intel_dp to store AS SDP v2 support
  drm/i915/dp: Allow AS SDP only if v2 is supported
  drm/i915/psr: Write the PR config DPCDs in burst mode
  drm/i915/display: Add helper for AS SDP transmission time selection
  drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission
    time
  drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless
    ALPM
  drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off
  drm/i915/dp: Split AS SDP computation between compute_config and
    compute_config_late
  drm/i915/dp: Compute and include coasting vtotal for AS SDP
  drm/i915/dp: Always enable AS SDP if supported by source + sink

 drivers/gpu/drm/display/drm_dp_helper.c       |  39 +++-
 drivers/gpu/drm/i915/display/intel_alpm.c     |  20 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   9 +-
 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 187 +++++++++++++++---
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 .../drm/i915/display/intel_dp_link_training.c |  15 +-
 .../drm/i915/display/intel_dp_link_training.h |   3 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   2 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |  40 ++--
 drivers/gpu/drm/i915/display/intel_psr.h      |   1 +
 drivers/gpu/drm/i915/display/intel_vrr.c      |  10 +
 include/drm/display/drm_dp.h                  |  20 +-
 include/drm/display/drm_dp_helper.h           |   1 +
 14 files changed, 288 insertions(+), 62 deletions(-)

-- 
2.45.2


             reply	other threads:[~2026-04-08  8:57 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  8:42 Ankit Nautiyal [this message]
2026-04-08  8:42 ` [PATCH 01/26] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 02/26] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 03/26] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 04/26] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 05/26] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 06/26] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 07/26] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 08/26] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 09/26] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 10/26] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 11/26] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 12/26] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 13/26] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 14/26] drm/i915/dp: Set sdp_type in AS SDP unpack Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 15/26] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 16/26] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 17/26] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 18/26] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 19/26] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 20/26] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 21/26] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 22/26] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 23/26] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 24/26] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 25/26] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 26/26] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-12  2:51 ` Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408084239.1295325-1-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox