From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/dp: Always enable AS SDP if supported by source + sink
Date: Sun, 12 Apr 2026 12:51:30 +1000 [thread overview]
Message-ID: <review-patch26-20260408084239.1295325-27-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260408084239.1295325-27-ankit.k.nautiyal@intel.com>
Patch Review
Changes `intel_dp_needs_as_sdp()` to enable AS SDP when:
1. Aux-less ALPM is active and async video timing is NOT supported (sink requires AS SDP during PR active), OR
2. VRR is *possible* (`intel_vrr_possible()` rather than `vrr.enable`)
The change from `vrr.enable` to `intel_vrr_possible()` is significant. `intel_vrr_possible()` checks `crtc_state->vrr.flipline` (which is set when the mode is within VRR range), meaning AS SDP is enabled even when VRR is not currently active but the display could support it. The commit message justifies this: turning on VRR later would otherwise require a full modeset to increase the guardband.
However, this means AS SDP bandwidth is always reserved for VRR-capable panels even if VRR is never used. The tradeoff is acceptable for correctness.
Missing R-b.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 2:51 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:42 [PATCH 00/26] Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Ankit Nautiyal
2026-04-08 8:42 ` [PATCH 01/26] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 02/26] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 03/26] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 04/26] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 05/26] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 06/26] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 07/26] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 08/26] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 09/26] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 10/26] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 11/26] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 12/26] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 13/26] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 14/26] drm/i915/dp: Set sdp_type in AS SDP unpack Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 15/26] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 16/26] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 17/26] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 18/26] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 19/26] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 20/26] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 21/26] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 22/26] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 23/26] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 24/26] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 25/26] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-12 2:51 ` Claude review: " Claude Code Review Bot
2026-04-08 8:42 ` [PATCH 26/26] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-04-12 2:51 ` Claude Code Review Bot [this message]
2026-04-12 2:51 ` Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-30 4:06 [PATCH 00/19] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Ankit Nautiyal
2026-03-30 4:06 ` [PATCH 19/19] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-03-31 7:39 ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 [PATCH 00/19] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Ankit Nautiyal
2026-03-11 11:36 ` [PATCH 19/19] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-03-11 20:55 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch26-20260408084239.1295325-27-ankit.k.nautiyal@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox