public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 26/26] drm/i915/dp: Always enable AS SDP if supported by source + sink
Date: Wed,  8 Apr 2026 14:12:38 +0530	[thread overview]
Message-ID: <20260408084239.1295325-27-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com>

Currently AS SDP is only configured when VRR is enabled. However, other
use cases like CMRR, Panel Replay, etc. also send information to the sink
via AS SDPs.

With optimized guardband, we also need to account for wakeup time and other
relevant details that depend on the AS SDP position whenever AS SDP is
enabled. If a feature enabling AS SDP gets turned on later (after modeset),
the guardband might not be sufficient and may need to increase, triggering
a full modeset.

To avoid this, always send AS SDP whenever:
 - the source and sink both support it, AND,
 - there is a possibility to use it for VRR and Panel Replay for
   synchronization.

v2: Check if AS SDP can be used for synchronization for VRR or PR. (Ville)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6e6d46cf62de..23daf90b701e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3136,7 +3136,11 @@ static bool intel_dp_needs_as_sdp(struct intel_dp *intel_dp,
 	if (drm_dp_is_branch(intel_dp->dpcd))
 		return false;
 
-	return crtc_state->vrr.enable;
+	if (intel_alpm_is_alpm_aux_less(intel_dp, crtc_state) &&
+	    !intel_psr_pr_async_video_timing_supported(intel_dp))
+		return true;
+
+	return intel_vrr_possible(crtc_state);
 }
 
 static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
-- 
2.45.2


  parent reply	other threads:[~2026-04-08  8:58 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  8:42 [PATCH 00/26] Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Ankit Nautiyal
2026-04-08  8:42 ` [PATCH 01/26] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 02/26] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 03/26] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 04/26] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 05/26] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 06/26] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 07/26] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 08/26] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 09/26] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 10/26] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 11/26] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 12/26] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 13/26] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 14/26] drm/i915/dp: Set sdp_type in AS SDP unpack Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 15/26] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 16/26] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 17/26] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 18/26] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 19/26] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 20/26] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 21/26] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 22/26] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 23/26] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 24/26] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 25/26] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` Ankit Nautiyal [this message]
2026-04-12  2:51   ` Claude review: drm/i915/dp: Always enable AS SDP if supported by source + sink Claude Code Review Bot
2026-04-12  2:51 ` Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408084239.1295325-27-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox