public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 04/26] drm/dp: Add DPCD for configuring AS SDP for PR + VRR
Date: Wed,  8 Apr 2026 14:12:16 +0530	[thread overview]
Message-ID: <20260408084239.1295325-5-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com>

Add additional DPCDs required to be configured to support VRR with Panel
Replay. These DPCDs are specifically required for configuring Adaptive Sync
SDP and are introduced in DP v2.1.

v2:
 - Correct the shift for the bits. (Ville)
 - Add DP_PR_ prefix for the PR-related fields.
v3:
 - Use macro values in their shifted form to match the convention. (Ville)
v4:
 - Add macro for the mask. (Ville)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 include/drm/display/drm_dp.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
index 8d172863eba3..829e4d98d61c 100644
--- a/include/drm/display/drm_dp.h
+++ b/include/drm/display/drm_dp.h
@@ -718,6 +718,12 @@
 #define DP_EXTENDED_DPRX_SLEEP_WAKE_TIMEOUT_GRANT	    0x119   /* 1.4a */
 # define DP_DPRX_SLEEP_WAKE_TIMEOUT_PERIOD_GRANTED	    (1 << 0)
 
+#define PANEL_REPLAY_CONFIG3			0x11a /* DP 2.1 */
+# define DP_PR_AS_SDP_SETUP_TIME_MASK		(3 << 6)
+# define DP_PR_AS_SDP_SETUP_TIME_T1		(0 << 6)
+# define DP_PR_AS_SDP_SETUP_TIME_DYNAMIC	(1 << 6) /* DP 2.1 Table 2-227 */
+# define DP_PR_AS_SDP_SETUP_TIME_T2		(2 << 6)
+
 #define DP_FEC_CONFIGURATION		    0x120    /* 1.4 */
 # define DP_FEC_READY			    (1 << 0)
 # define DP_FEC_ERR_COUNT_SEL_MASK	    (7 << 1)
-- 
2.45.2


  parent reply	other threads:[~2026-04-08  8:57 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  8:42 [PATCH 00/26] Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Ankit Nautiyal
2026-04-08  8:42 ` [PATCH 01/26] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 02/26] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 03/26] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` Ankit Nautiyal [this message]
2026-04-12  2:51   ` Claude review: drm/dp: Add DPCD for configuring AS SDP for PR + VRR Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 05/26] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 06/26] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 07/26] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 08/26] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 09/26] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 10/26] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 11/26] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 12/26] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 13/26] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 14/26] drm/i915/dp: Set sdp_type in AS SDP unpack Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 15/26] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 16/26] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 17/26] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 18/26] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 19/26] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 20/26] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 21/26] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 22/26] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 23/26] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 24/26] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 25/26] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 26/26] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-12  2:51 ` Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408084239.1295325-5-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox