public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 22/26] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM
Date: Wed,  8 Apr 2026 14:12:34 +0530	[thread overview]
Message-ID: <20260408084239.1295325-23-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com>

If a Panel Replay capable sink, supports Async Video timing in
PR active state, then source does not necessarily need to send AS SDPs
during PR active.

However, if asynchronous video timing is not supported, then for PR with
Aux-less ALPM, the source must transmit Adaptive-Sync SDPs for video
timing synchronization while PR is active.

If the source needs to send AS SDP during PR active, this requires setting
DPCD 0x0107[6] (FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE). This applies whether
VRR is enabled (AVT/FAVT) or fixed-timing mode is used.

This bit defines AS SDP timing behavior during PR Active, even if AS SDPs
are briefly suspended.

Program the relevant Downspread Ctrl DPCD bits accordingly.

v2: Instead of Panel Replay check simply use AS SDP enable check. (Ville)
v3: Since the bit is defined in context of Panel Replay and AS SDP, add
    a check for both. (Ville)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 .../gpu/drm/i915/display/intel_dp_link_training.c | 15 +++++++++++++--
 .../gpu/drm/i915/display/intel_dp_link_training.h |  3 ++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c       |  2 +-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index a26094223f78..d0b033d2cfb4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -34,8 +34,10 @@
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
 #include "intel_encoder.h"
+#include "intel_hdmi.h"
 #include "intel_hotplug.h"
 #include "intel_panel.h"
+#include "intel_psr.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
 #define LT_MSG_ARGS(_intel_dp, _dp_phy)	(_intel_dp)->attached_connector->base.base.id, \
@@ -710,11 +712,14 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp,
 	return true;
 }
 
-void intel_dp_link_training_set_mode(struct intel_dp *intel_dp, int link_rate, bool is_vrr)
+void intel_dp_link_training_set_mode(struct intel_dp *intel_dp, int link_rate,
+				     bool is_vrr,
+				     bool pr_with_as_sdp_enable)
 {
 	u8 link_config[2];
 
 	link_config[0] = is_vrr ? DP_MSA_TIMING_PAR_IGNORE_EN : 0;
+	link_config[0] |= pr_with_as_sdp_enable ? DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE : 0;
 	link_config[1] = drm_dp_is_uhbr_rate(link_rate) ?
 			 DP_SET_ANSI_128B132B : DP_SET_ANSI_8B10B;
 	drm_dp_dpcd_write(&intel_dp->aux, DP_DOWNSPREAD_CTRL, link_config, 2);
@@ -723,6 +728,10 @@ void intel_dp_link_training_set_mode(struct intel_dp *intel_dp, int link_rate, b
 static void intel_dp_update_downspread_ctrl(struct intel_dp *intel_dp,
 					    const struct intel_crtc_state *crtc_state)
 {
+	bool pr_with_as_sdp_enable =
+		intel_psr_needs_alpm_aux_less(intel_dp, crtc_state) &&
+		crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
+
 	 /*
 	  * Currently, we set the MSA ignore bit based on vrr.in_range.
 	  * We can't really read that out during driver load since we don't have
@@ -737,7 +746,9 @@ static void intel_dp_update_downspread_ctrl(struct intel_dp *intel_dp,
 	  * especially on the first real commit when clearing the inherited flag.
 	  */
 	intel_dp_link_training_set_mode(intel_dp,
-					crtc_state->port_clock, crtc_state->vrr.in_range);
+					crtc_state->port_clock,
+					crtc_state->vrr.in_range,
+					pr_with_as_sdp_enable);
 }
 
 void intel_dp_link_training_set_bw(struct intel_dp *intel_dp,
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.h b/drivers/gpu/drm/i915/display/intel_dp_link_training.h
index 33dcbde6a408..18c34c1a472f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.h
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.h
@@ -18,7 +18,8 @@ int intel_dp_init_lttpr_and_dprx_caps(struct intel_dp *intel_dp);
 bool intel_dp_lttpr_transparent_mode_enabled(struct intel_dp *intel_dp);
 
 void intel_dp_link_training_set_mode(struct intel_dp *intel_dp,
-				     int link_rate, bool is_vrr);
+				     int link_rate, bool is_vrr,
+				     bool pr_with_as_sdp_enable);
 void intel_dp_link_training_set_bw(struct intel_dp *intel_dp,
 				   int link_bw, int rate_select, int lane_count,
 				   bool enhanced_framing, bool post_lt_adj_req);
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index e8de17834dcd..ffd1cf0aad9a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -2142,7 +2142,7 @@ void intel_dp_mst_prepare_probe(struct intel_dp *intel_dp)
 
 	intel_dp_compute_rate(intel_dp, link_rate, &link_bw, &rate_select);
 
-	intel_dp_link_training_set_mode(intel_dp, link_rate, false);
+	intel_dp_link_training_set_mode(intel_dp, link_rate, false, false);
 	intel_dp_link_training_set_bw(intel_dp, link_bw, rate_select, lane_count,
 				      drm_dp_enhanced_frame_cap(intel_dp->dpcd), false);
 
-- 
2.45.2


  parent reply	other threads:[~2026-04-08  8:58 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  8:42 [PATCH 00/26] Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Ankit Nautiyal
2026-04-08  8:42 ` [PATCH 01/26] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 02/26] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 03/26] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 04/26] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 05/26] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 06/26] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 07/26] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 08/26] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 09/26] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 10/26] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 11/26] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 12/26] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 13/26] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 14/26] drm/i915/dp: Set sdp_type in AS SDP unpack Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 15/26] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 16/26] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 17/26] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 18/26] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 19/26] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 20/26] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 21/26] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` Ankit Nautiyal [this message]
2026-04-12  2:51   ` Claude review: drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 23/26] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 24/26] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 25/26] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-08  8:42 ` [PATCH 26/26] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-04-12  2:51   ` Claude review: " Claude Code Review Bot
2026-04-12  2:51 ` Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408084239.1295325-23-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox