[PATCH] drm: Remove unused header in drm_dumb_buffers.c

[PATCH] drm: Remove unused header in drm_dumb_buffers.c

[Yicong Hui]

Remove the header #include "drm_internal.h" from drm_dumb_buffers.c,
which is included but not used.

Header was introduced in 47f10854ca89 when moving functions, but was
not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was
removed.

Compiles successfully with DRM enabled, pass kunit tests and
IGT-tests in a vng virtual machine.

Fixes: 96a7b60f6ddb ("drm: remove dumb_destroy callback")
Signed-off-by: Yicong Hui <yiconghui@gmail.com>
---
 drivers/gpu/drm/drm_dumb_buffers.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
index e2b62e5fb891..61bf3c9b7182 100644
--- a/drivers/gpu/drm/drm_dumb_buffers.c
+++ b/drivers/gpu/drm/drm_dumb_buffers.c
@@ -32,7 +32,6 @@
 #include <drm/drm_print.h>
 
 #include "drm_crtc_internal.h"
-#include "drm_internal.h"
 
 /**
  * DOC: overview
-- 
2.53.0

Claude review: drm: Remove unused header in drm_dumb_buffers.c

[Claude Code Review Bot]

Overall Series Review

Subject: drm: Remove unused header in drm_dumb_buffers.c
Author: Yicong Hui <yiconghui@gmail.com>
Patches: 1
Reviewed: 2026-04-12T10:55:27.497281

---

This is a single-patch series that removes an unused `#include "drm_internal.h"` from `drm_dumb_buffers.c`. The change is trivially correct.

The commit message is well-written: it explains the provenance of the include (added by commit `47f10854ca89` when functions were moved to this file) and why it became unnecessary (commit `96a7b60f6ddb` removed `drm_gem_dumb_destroy`, which was the last user of declarations from that header). The testing described (build with DRM enabled, kunit, IGT in a VM) is appropriate for the scope.

**Verdict: Looks good.** No issues found.

---
Generated by Claude Code Patch Reviewer

Claude review: drm: Remove unused header in drm_dumb_buffers.c

[Claude Code Review Bot]

Patch Review

**Result: No issues.**

The patch removes:
```c
-#include "drm_internal.h"
```

I verified this is correct by cross-referencing the symbols used in `drm_dumb_buffers.c` against the declarations in `drm_internal.h`:

- `drm_gem_handle_delete()` — declared in `<drm/drm_gem.h>` (line 584), **not** in `drm_internal.h`
- `drm_gem_dumb_map_offset()` — declared in `<drm/drm_gem.h>`, **not** in `drm_internal.h`
- `drm_mode_create_dumb_ioctl()`, `drm_mode_mmap_dumb_ioctl()`, `drm_mode_destroy_dumb_ioctl()` — declared in `drm_crtc_internal.h` (lines 116-120), which remains included
- All other symbols come from the public `<drm/*.h>` headers already included

No symbol used by `drm_dumb_buffers.c` is declared in `drm_internal.h`. The remaining include of `drm_crtc_internal.h` covers the internal declarations this file needs.

The `Fixes:` tag referencing `96a7b60f6ddb` is reasonable — that's the commit that removed `drm_gem_dumb_destroy()`, which was the last function requiring `drm_internal.h`. Minor nit: some maintainers might prefer not to use a `Fixes:` tag for a cosmetic cleanup since nothing is functionally broken, but this is a matter of style/preference and not worth blocking on.

---
Generated by Claude Code Patch Reviewer