[PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error

[PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error

[Christian Van]

mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
currently ignores it and always reports success.

Return the DCS command result so callers can observe enable failures.

Signed-off-by: Christian Van <cvan20191@gmail.com>
---
 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
index 4f8d6d8c0..dbdb7e3cb 100644
--- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
+++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
@@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
 	/* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
 	msleep(200);
 
-	mipi_dsi_dcs_set_display_on(ctx->dsi);
-
-	return 0;
+	return mipi_dsi_dcs_set_display_on(ctx->dsi);
 }
 
 static int feiyang_disable(struct drm_panel *panel)
-- 
2.43.0

Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error

[Neil Armstrong]

On 4/25/26 07:39, Christian Van wrote:
> mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
> currently ignores it and always reports success.
> 
> Return the DCS command result so callers can observe enable failures.
> 
> Signed-off-by: Christian Van <cvan20191@gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> index 4f8d6d8c0..dbdb7e3cb 100644
> --- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> @@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
>   	/* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
>   	msleep(200);
>   
> -	mipi_dsi_dcs_set_display_on(ctx->dsi);
> -
> -	return 0;
> +	return mipi_dsi_dcs_set_display_on(ctx->dsi);
>   }
>   
>   static int feiyang_disable(struct drm_panel *panel)

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

Claude review: drm/panel: feiyang-fy07024di26a30d: return display-on error

[Claude Code Review Bot]

Overall Series Review

Subject: drm/panel: feiyang-fy07024di26a30d: return display-on error
Author: Christian Van <cvan20191@gmail.com>
Patches: 2
Reviewed: 2026-04-28T15:39:46.222813

---

This is a single-patch series that fixes a minor bug in the Feiyang FY07024DI26A30D panel driver where the return value of `mipi_dsi_dcs_set_display_on()` was being silently discarded in `feiyang_enable()`. The fix is straightforward and correct.

The change is consistent with how the same driver already handles `mipi_dsi_dcs_set_display_off()` in `feiyang_disable()` (line 110), which does return the result directly. There's an asymmetry that the existing `_enable` ignored the error while `_disable` propagated it — this patch resolves that inconsistency.

The commit message is clear and accurately describes the problem and the fix. No concerns with this patch.

**Verdict: Looks good.** This is a trivially correct one-liner bug fix.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/panel: feiyang-fy07024di26a30d: return display-on error

[Claude Code Review Bot]

Patch Review

**Correctness: Good.**

The original code:
```c
mipi_dsi_dcs_set_display_on(ctx->dsi);

return 0;
```
discards the return value from `mipi_dsi_dcs_set_display_on()`, unconditionally returning success. The replacement:
```c
return mipi_dsi_dcs_set_display_on(ctx->dsi);
```
correctly propagates any error to the caller.

**Consistency with the rest of the driver: Good.** The sibling function `feiyang_disable()` at line 110 already does exactly this pattern with `mipi_dsi_dcs_set_display_off()`:
```c
static int feiyang_disable(struct drm_panel *panel)
{
	struct feiyang *ctx = panel_to_feiyang(panel);

	return mipi_dsi_dcs_set_display_off(ctx->dsi);
}
```
So this patch makes `_enable` consistent with `_disable`.

**Minor observation (not blocking):** The `feiyang_unprepare()` function (line 113) takes a different approach — it checks the return value of `mipi_dsi_dcs_set_display_off()` and logs an error with `dev_err()` before continuing. One could argue that logging the error in `feiyang_enable()` before returning it would aid debugging, but the `_disable` function doesn't log either, so the patch as written is consistent with the existing pattern for the enable/disable pair. This is a style choice and not something that should block acceptance.

**Reviewed-by worthy.** No issues found.

---
Generated by Claude Code Patch Reviewer