Claude review: Introduce cold reset recovery method

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Introduce cold reset recovery method
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Patches: 6
Reviewed: 2026-05-25T21:57:08.799531

---

This v6 series adds a `DRM_WEDGE_RECOVERY_COLD_RESET` recovery method for Intel Xe GPUs, targeting PUNIT errors that persist across warm resets and require a full slot power cycle. The design is sound: detect the error via RAS infrastructure, wedge the device, emit a uevent, and let userspace perform the power cycle.

The DRM core change (patch 2) is clean and minimal. The documentation (patch 3) is well-written with a practical example script. The PUNIT handler (patch 4) correctly uses the wedge API. The AER SLD suppression (patch 5) is architecturally sensible but has a concern about the mask never being restored on failure.

Patch 1 is marked "DO NOT REVIEW - COMPILATION ONLY" but has a clear uninitialized variable bug and a wedge API bypass that could trigger an assertion, which I flag below for completeness since it ships as part of this build.

**Key concerns:**
- Uninitialized variable in `handle_page_offline()` (patch 1)
- `xe_pci_error_handling()` bypasses `xe_device_declare_wedged()` and could hit the `xe_gt_assert` if `wedged.mode == XE_WEDGED_MODE_NEVER` (patch 1)
- Duplicate `XE_SYSCTRL_FLOOD` macro definition across two headers (patch 1)
- SLD mask in patch 5 is never restored if cold reset fails or is never performed

---

---
Generated by Claude Code Patch Reviewer