Claude review: Introduce cold reset recovery method

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Introduce cold reset recovery method
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Patches: 12
Reviewed: 2026-05-16T13:17:48.673793

---

This v5 series introduces cold reset recovery for Intel Xe GPUs through the DRM wedge infrastructure. The architecture is: system controller reports hardware errors (PUNIT, memory, compute) via RAS, and when a PUNIT error is detected that persists across warm resets, the driver wedges the device with `DRM_WEDGE_RECOVERY_COLD_RESET`, notifying userspace to power-cycle the slot.

**Patch 1** is a dependency blob from a separate series (explicitly marked "DO NOT REVIEW"), so I'll focus on patches 2-5. The overall design of adding a new recovery method to the DRM wedge framework is straightforward and clean. However, there are several issues ranging from a compile-breaking bug to a duplicate `#define`.

**Key issues:**
1. **Critical bug (Patch 1):** `handle_page_offline()` uses `ret` uninitialized in a `switch` statement — the call that should set it is commented out as a TODO. This is undefined behavior and will be flagged by the compiler.
2. **Duplicate define (Patch 1):** `XE_SYSCTRL_FLOOD` is defined in both `xe_sysctrl_event_types.h` and `xe_sysctrl_mailbox_types.h`.
3. **Patch 5 naming:** Static functions use the `pcie_` prefix which could be confused with PCI core API functions.

---

---
Generated by Claude Code Patch Reviewer