public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method
Date: Sat, 16 May 2026 13:17:49 +1000	[thread overview]
Message-ID: <review-patch3-20260512132614.1793083-10-mallesh.koujalagi@intel.com> (raw)
In-Reply-To: <20260512132614.1793083-10-mallesh.koujalagi@intel.com>

Patch Review

The documentation is generally good. A few observations:

**Recovery script lacks error handling**

The example `cold-reset.sh` script does not check the return status of critical operations:
```sh
	echo 1 > /sys/bus/pci/devices/$DEVICE/remove
	echo 0 > /sys/bus/pci/slots/$SLOT/power
	sleep 2
	echo 1 > /sys/bus/pci/slots/$SLOT/power
```

If `remove` fails or `power` writes fail, the script continues silently. While this is an example script and not production code, adding basic error checks (`set -e` or explicit checks) would be good practice for documentation that users will copy.

**Minor: the "No slot found" case has no guidance**

```sh
    else
	echo "No slot found"
    fi
```

When no slot is found, the script gives no guidance on what to do. A comment suggesting a system-level power cycle or BMC-assisted reset would help operators.

**Table update is correct:**

```
    cold-reset      remove device + slot power cycle + rescan
```

This matches the `#define` comment from patch 2.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  3:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 13:26 [PATCH v5 0/5] Introduce cold reset recovery method Mallesh Koujalagi
2026-05-12 13:26 ` [PATCH v5 1/5] Introduce Xe Uncorrectable Error Handling Mallesh Koujalagi
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 2/5] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-05-14  7:59   ` Raag Jadav
2026-05-14  9:12   ` Tauro, Riana
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 3/5] drm/doc: Document " Mallesh Koujalagi
2026-05-14  8:50   ` Raag Jadav
2026-05-16  3:17   ` Claude Code Review Bot [this message]
2026-05-12 13:26 ` [PATCH v5 4/5] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-05-14  8:13   ` Raag Jadav
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 5/5] drm/xe: Suppress Surprise Link Down on non-hotplug device Mallesh Koujalagi
2026-05-14  8:35   ` Raag Jadav
2026-05-14  9:36   ` Tauro, Riana
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-16  3:17 ` Claude review: Introduce cold reset recovery method Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-06 14:23 [PATCH v3 0/4] " Mallesh Koujalagi
2026-04-06 14:23 ` [PATCH v3 3/4] drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET " Mallesh Koujalagi
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260512132614.1793083-10-mallesh.koujalagi@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox